Merge pull request #249 from nextcloud/bugfix/noid/notification-handling

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti…

Author: nickvergessen

lib/Notification/Notifier.php

@@ -11,15 +11,14 @@
 
 namespace OCA\Approval\Notification;
 
-use InvalidArgumentException;
 use OCA\Approval\AppInfo\Application;
 use OCP\IURLGenerator;
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\L10N\IFactory;
 use OCP\Notification\INotification;
-
 use OCP\Notification\INotifier;
+use OCP\Notification\UnknownNotificationException;
 
 class Notifier implements INotifier {
 
@@ -53,13 +52,13 @@ public function getName(): string {
 	 * @param INotification $notification
 	 * @param string $languageCode The code of the language that should be used to prepare the notification
 	 * @return INotification
-	 * @throws InvalidArgumentException When the notification was not prepared by a notifier
+	 * @throws UnknownNotificationException When the notification was not prepared by a notifier
 	 * @since 9.0.0
 	 */
 	public function prepare(INotification $notification, string $languageCode): INotification {
 		if ($notification->getApp() !== Application::APP_ID) {
 			// Not my app => throw
-			throw new InvalidArgumentException();
+			throw new UnknownNotificationException();
 		}
 
 		$l = $this->factory->get(Application::APP_ID, $languageCode);
@@ -163,7 +162,7 @@ public function prepare(INotification $notification, string $languageCode): INot
 
 			default:
 				// Unknown subject => Unknown notification => throw
-				throw new InvalidArgumentException();
+				throw new UnknownNotificationException();
 		}
 	}
 }