Activity rich param id needs to be a string #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
reviewed
Mar 11, 2025
| 'id' => (string)$event->getObjectId(), | ||
| 'name' => $event->getObjectName(), | ||
| 'path' => $path, | ||
| 'path' => trim($path, '/'), |
Member
There was a problem hiding this comment.
Why trim the slash from the beginning?
Member
Author
There was a problem hiding this comment.
Because they do so there: https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Activity/Providers/Base.php#L109
but no strong reason.
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/268/activity-string-richparam-id
branch
from
ec7197f to
4ec43dc
Compare
marcelklehr
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #268
Also, add file link for the activity rich param to point to the files app.