fix: hard to translate portions #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
nickvergessen
requested changes
Jun 13, 2025
| return '' | ||
| }, | ||
| approvedByText() { | ||
| return t('approval', 'Approved by {user}', { user: this.notMe ? this.userName : this.you }) |
There was a problem hiding this comment.
You need to make proper if blocks
Approved by You does not work in german
There was a problem hiding this comment.
True, to reformulate, you need a specific translation for "approved by you" and "approved by DISPLAY_NAME".
There was a problem hiding this comment.
Thanks. I made a new pr #304 that hopefully implements it correctly this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #70