-
Notifications
You must be signed in to change notification settings - Fork 8
Update to Vue 3 and switch to Vite #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The v-tooltips do not work. They can be replaced by a simple
title
attr - [Unrelated] You should change the app version number when making a PR that contains DB migrations. I forgot to tell you in the PR adding the
unapprove_when_modified
column. Let's do it here. You can bump the 2nd digit. - [Unrelated] Line 286 of AdminSettings.vue, the
unapproveWhenModified
value should be a boolean. This breaks the creation of a new rule in the UI. Vue complains about theNcCheckboxRadioSwitch
model-value prop type and crashes.
Otherwise, all good 👍
Also those tooltips should probably not be there when you aren't the admin. |
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Even the + buttons should be hidden on the same condition as the "create new hidden tag" input. |
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
I had removed the buttons and the tooltips my comment just didn't mention that 👍 That should now be everything you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.