Merge pull request #351 from nextcloud/fix/noid/audio-attachment-check

Prevent accessing array index on null

Author: julien-nc

lib/Controller/ChattyLLMController.php

@@ -500,8 +500,9 @@ public function generateForSession(int $sessionId, int $agencyConfirm = 0): JSON
 
 			$lastAttachments = $lastUserMessage->jsonSerialize()['attachments'];
 			$audioAttachment = $lastAttachments[0] ?? null;
-			$audioAttachment = $audioAttachment['type'] === 'Audio' ? $audioAttachment : null;
 			if ($audioAttachment !== null
+				&& isset($audioAttachment['type'])
+				&& $audioAttachment['type'] === 'Audio'
 				&& class_exists('OCP\\TaskProcessing\\TaskTypes\\ContextAgentAudioInteraction')
 				&& isset($this->taskProcessingManager->getAvailableTaskTypes()[\OCP\TaskProcessing\TaskTypes\ContextAgentAudioInteraction::ID])
 			) {
@@ -535,13 +536,9 @@ public function generateForSession(int $sessionId, int $agencyConfirm = 0): JSON
 
 			$lastAttachments = $lastUserMessage->jsonSerialize()['attachments'];
 			$audioAttachment = $lastAttachments[0] ?? null;
-			$audioAttachment = $audioAttachment['type'] === 'Audio' ? $audioAttachment : null;
-			/* php 8.4 allows:
-			$audioAttachment = array_find($lastAttachments, static function (array $attachment) {
-				return $attachment['type'] === 'Audio';
-			});
-			*/
 			if ($audioAttachment !== null
+				&& isset($audioAttachment['type'])
+				&& $audioAttachment['type'] === 'Audio'
 				&& class_exists('OCP\\TaskProcessing\\TaskTypes\\AudioToAudioChat')
 				&& isset($this->taskProcessingManager->getAvailableTaskTypes()[\OCP\TaskProcessing\TaskTypes\AudioToAudioChat::ID])
 			) {