Skip to content

Commit f45df72

Browse files
committed
feat(audio-chat): remove fallback task type, register provider only if the server task type exists
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
1 parent 15b656c commit f45df72

File tree

3 files changed

+13
-18
lines changed

3 files changed

+13
-18
lines changed

lib/AppInfo/Application.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
use OCA\Assistant\Reference\TaskOutputFileReferenceProvider;
2424
use OCA\Assistant\Reference\Text2ImageReferenceProvider;
2525
use OCA\Assistant\TaskProcessing\AudioToAudioChatProvider;
26-
use OCA\Assistant\TaskProcessing\AudioToAudioChatTaskType;
2726
use OCP\AppFramework\App;
2827
use OCP\AppFramework\Bootstrap\IBootContext;
2928

@@ -73,8 +72,9 @@ public function register(IRegistrationContext $context): void {
7372

7473
$context->registerEventListener(AddContentSecurityPolicyEvent::class, CSPListener::class);
7574

76-
$context->registerTaskProcessingTaskType(AudioToAudioChatTaskType::class);
77-
$context->registerTaskProcessingProvider(AudioToAudioChatProvider::class);
75+
if (class_exists('OCP\\TaskProcessing\\TaskTypes\\AudioToAudioChat')) {
76+
$context->registerTaskProcessingProvider(AudioToAudioChatProvider::class);
77+
}
7878
}
7979

8080
public function boot(IBootContext $context): void {

lib/TaskProcessing/AudioToAudioChatProvider.php

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@
1414
use OCA\Assistant\Service\TaskProcessingService;
1515
use OCP\Files\File;
1616
use OCP\IL10N;
17-
use OCP\TaskProcessing\EShapeType;
1817
use OCP\TaskProcessing\ISynchronousProvider;
19-
use OCP\TaskProcessing\ShapeDescriptor;
2018
use OCP\TaskProcessing\Task;
19+
use OCP\TaskProcessing\TaskTypes\AudioToAudioChat;
2120
use OCP\TaskProcessing\TaskTypes\AudioToText;
2221
use OCP\TaskProcessing\TaskTypes\TextToSpeech;
2322
use OCP\TaskProcessing\TaskTypes\TextToTextChat;
@@ -42,10 +41,7 @@ public function getName(): string {
4241
}
4342

4443
public function getTaskTypeId(): string {
45-
if (class_exists('OCP\\TaskProcessing\\TaskTypes\\AudioToAudioChat')) {
46-
return \OCP\TaskProcessing\TaskTypes\AudioToAudioChat::ID;
47-
}
48-
return AudioToAudioChatTaskType::ID;
44+
return AudioToAudioChat::ID;
4945
}
5046

5147
public function getExpectedRuntime(): int {
@@ -78,13 +74,7 @@ public function getOutputShapeEnumValues(): array {
7874
}
7975

8076
public function getOptionalOutputShape(): array {
81-
return [
82-
'input_transcript' => new ShapeDescriptor(
83-
$this->l->t('Input transcript'),
84-
$this->l->t('Input transcription'),
85-
EShapeType::Text,
86-
),
87-
];
77+
return [];
8878
}
8979

9080
public function getOptionalOutputShapeEnumValues(): array {

lib/TaskProcessing/AudioToAudioChatTaskType.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,19 @@ public function getInputShape(): array {
7272
*/
7373
public function getOutputShape(): array {
7474
return [
75+
'input_transcript' => new ShapeDescriptor(
76+
$this->l->t('Input transcript'),
77+
$this->l->t('Transcription of the audio input'),
78+
EShapeType::Text,
79+
),
7580
'output' => new ShapeDescriptor(
7681
$this->l->t('Response voice message'),
77-
$this->l->t('The generated response as part of the conversation'),
82+
$this->l->t('The generated voice response as part of the conversation'),
7883
EShapeType::Audio
7984
),
8085
'output_transcript' => new ShapeDescriptor(
8186
$this->l->t('Output transcript'),
82-
$this->l->t('Response transcription'),
87+
$this->l->t('Transcription of the audio output'),
8388
EShapeType::Text,
8489
),
8590
];

0 commit comments

Comments
 (0)