Skip to content

Fix incorrect task type prop set when trying again #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix incorrect task type prop set when trying again #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/assistant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,13 @@ export async function openAssistantForm({
syncSubmit(data.inputs, data.selectedTaskTypeId, customId || identifier)
})
view.$on('try-again', (task) => {
syncSubmit(task.input, task.taskType)
console.debug('[assistant] try again', task)
syncSubmit(task.input, task.type)
})
view.$on('load-task', (task) => {
if (!view.loading) {
console.debug('[assistant] loading task', task)
view.selectedTaskTypeId = task.taskType
view.selectedTaskTypeId = task.type
view.inputs = task.input
view.outputs = task.status === TASK_STATUS_STRING.successful ? task.output : null
view.selectedTaskId = task.id
Expand Down Expand Up @@ -396,11 +397,11 @@ export async function openAssistantTask(task, { isInsideViewer = undefined, acti
syncSubmit(data.inputs, data.selectedTaskTypeId, task.identifier ?? '')
})
view.$on('try-again', (task) => {
syncSubmit(task.input, task.taskType)
syncSubmit(task.input, task.type)
})
view.$on('load-task', (task) => {
if (!view.loading) {
view.selectedTaskTypeId = task.taskType
view.selectedTaskTypeId = task.type
view.inputs = task.input
view.outputs = task.status === TASK_STATUS_STRING.successful ? task.output : null
view.selectedTaskId = task.id
Expand Down
4 changes: 2 additions & 2 deletions src/views/AssistantPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
:selected-task-id="task.id"
:inputs="task.input"
:outputs="task.output"
:selected-task-type-id="task.taskType"
:selected-task-type-id="task.type"
:loading="loading"
@sync-submit="onSyncSubmit"
@try-again="onTryAgain"
Expand Down Expand Up @@ -111,7 +111,7 @@ export default {
this.showSyncTaskRunning = true
this.progress = null
this.task.input = inputs
this.task.taskType = taskTypeId
this.task.type = taskTypeId
scheduleTask('assistant', this.task.identifier, taskTypeId, inputs)
.then((response) => {
console.debug('Assistant SYNC result', response.data?.ocs?.data)
Expand Down
Loading