Skip to content

Hide ChatWithTools and ContextAgentInteraction task types #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Hide ChatWithTools and ContextAgentInteraction task types #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions lib/Service/AssistantService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,17 @@ public function getAvailableTaskTypes(): array {
}
/** @var string $typeId */
foreach ($availableTaskTypes as $typeId => $taskTypeArray) {
// skip chat task type (not directly useful to the end user)
// skip chat, chat with tools and ContextAgent task types (not directly useful to the end user)
if (!self::DEBUG) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

if (class_exists('OCP\\TaskProcessing\\TaskTypes\\TextToTextChatWithTools')
&& $typeId === \OCP\TaskProcessing\TaskTypes\TextToTextChatWithTools::ID) {
continue;
}
if (class_exists('OCP\\TaskProcessing\\TaskTypes\\ContextAgentInteraction')
&& $typeId === \OCP\TaskProcessing\TaskTypes\ContextAgentInteraction::ID) {
continue;
}
}
if ($typeId === TextToTextChat::ID) {
// add the chattyUI virtual task type
$types[] = [
Expand All @@ -191,7 +201,9 @@ public function getAvailableTaskTypes(): array {
'priority' => self::TASK_TYPE_PRIORITIES['chatty-llm'] ?? 1000,
];
// do not add the raw TextToTextChat type
continue;
if (!self::DEBUG) {
continue;
}
}
$taskTypeArray['id'] = $typeId;
$taskTypeArray['priority'] = self::TASK_TYPE_PRIORITIES[$typeId] ?? 1000;
Expand Down
2 changes: 2 additions & 0 deletions tests/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
</MoreSpecificReturnType>
<RedundantCondition>
<code><![CDATA[!self::DEBUG]]></code>
<code><![CDATA[!self::DEBUG]]></code>
<code><![CDATA[!self::DEBUG]]></code>
</RedundantCondition>
<TypeDoesNotContainType>
<code><![CDATA[self::DEBUG]]></code>
Expand Down