Skip to content

Conversation

edward-ly
Copy link
Contributor

Resolves #212. Formatting and text may still need some adjusting, though.

20250415_17h00m05s_scrot

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected runtime is currently only displayed when the task is running (when the progress bar is being displayed). We get the task expected runtime value as soon as we schedule the task, before it is running. We could display it as soon as we have it. The delay between scheduling and running should not be long, i think it's fine to show the expected runtime even if the task is not running yet.

@jancborchardt @nimishavijay @edward-ly Wdyt?

@julien-nc
Copy link
Member

Hey @edward-ly . I think we can go with my suggested change. Show the expected runtime as soon as the task is scheduled (and not wait for it to be running).

@edward-ly edward-ly force-pushed the feat/expected-runtime branch from 7ef8ac4 to 7c8685c Compare April 30, 2025 17:08
@edward-ly
Copy link
Contributor Author

Done. I also removed the generic message when the runtime is not retrieved yet as it only flashed for a brief moment before the message changed afterwards.

@edward-ly edward-ly force-pushed the feat/expected-runtime branch from 7c8685c to a539c3c Compare April 30, 2025 18:19
Copy link
Member

@janepie janepie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! :)

Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly edward-ly force-pushed the feat/expected-runtime branch from a539c3c to fc9b588 Compare May 5, 2025 16:44
@edward-ly edward-ly merged commit dcd4d73 into main May 5, 2025
9 checks passed
@edward-ly edward-ly deleted the feat/expected-runtime branch May 5, 2025 16:46
@julien-nc julien-nc mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show rough estimated time
4 participants