Task output file download link reference #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edward-ly
reviewed
Apr 29, 2025
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
… a save button in MediaField Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…hen displayed on top Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/task-output-file-reference
branch
from
e543fb5 to
7800142
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 things:
<MediaField>)Remaining issue: The Viewer is not displayed on top of the assistant modal. Everything is fine if we open the viewer from a link widget in Talk, or from the assistant standalone page, but no luck if the assistant itself is already in a modal.
Solution: Change the NcModal
containerprop to#content. The Viewer is then displayed on top.Kooha-2025-04-28-11-38-41.webm