Skip to content

Add custom input and output forms for context_chat_search #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 28, 2025
Merged

Add custom input and output forms for context_chat_search #241

merged 7 commits into from
May 28, 2025

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented May 14, 2025 •
edited
Loading

This is related with

Custom forms:

  • Output: one NcRichText per source
  • Input: reuse the classic context chat input form but remove the "source" scope type and add the "limit" number field

image

@julien-nc julien-nc requested a review from kyteinsky May 14, 2025 09:54
@julien-nc julien-nc added enhancement New feature or request 3. to review labels May 14, 2025
@julien-nc julien-nc mentioned this pull request May 14, 2025
Merged
@kyteinsky kyteinsky mentioned this pull request May 26, 2025
Merged
@julien-nc julien-nc force-pushed the enh/noid/context-chat-search branch from 69b97d9 to 7642cea Compare May 26, 2025 11:16
kyteinsky
kyteinsky reviewed May 26, 2025
View reviewed changes
@julien-nc
Copy link
Member Author

"Limit" input field added (for search only). Adjusted the initial PR comment and added a screenshot.

kyteinsky
kyteinsky reviewed May 27, 2025
View reviewed changes
julien-nc added 3 commits May 27, 2025 16:52
@julien-nc
feat: start adding custom input and output forms for context_chat_search
ba175a2 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
feat: add limit input for context chat search
53936d7 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
feat: use classic number input for context chat search limit
eccdf37 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/context-chat-search branch from e97e8cd to eccdf37 Compare May 27, 2025 14:52
@julien-nc julien-nc marked this pull request as ready for review May 27, 2025 14:52
@julien-nc
fix: context chat input form not well initialized
f0ccd27 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/context-chat-search branch from 6a90c39 to 1f87349 Compare May 28, 2025 09:57
@julien-nc
feat(contact chat search): display result sources as a readable link
d437f9d 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/context-chat-search branch from 1f87349 to d437f9d Compare May 28, 2025 10:06
julien-nc and others added 2 commits May 28, 2025 14:42
@julien-nc
feat(contact chat search): make source list an ordered list, highligh…
39e7c50 
…t on hover

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@kyteinsky
css improvements
7f5e5e3 
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinsky
kyteinsky approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@julien-nc julien-nc merged commit c4d011b into main May 28, 2025
16 checks passed
@julien-nc julien-nc deleted the enh/noid/context-chat-search branch May 28, 2025 13:08
kyteinsky added a commit to nextcloud/context_chat_backend that referenced this pull request Jun 2, 2025
@kyteinsky
feat: add doc search endpoint (#185)
24d4b86 
related changes:
- nextcloud/context_chat#129
- nextcloud/assistant#241

---------

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@julien-nc julien-nc mentioned this pull request Jun 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyteinsky kyteinsky kyteinsky approved these changes

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-nc @kyteinsky