Make sure the assistant is mounted after the existing viewer #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewer is true Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
|
CI run to see if the failing text test passes again: nextcloud/text#7286 |
juliusknorr
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can already know if the assistant should be displayed on top of an existing viewer. The
isInsideViewerofopenAssistantTask()andopenAssistantForm()tells us that.So instead of asking integrators to specify a mount point for that case, we can automatically mount the assistant at the end of the
<body>.The
openAssistantTask()function has been adjusted to be consistent withopenAssistantTask().cc @juliusknorr