Remove dialog header and duplicate title

[marcoambrosini]

requires https://github.com/nextcloud-libraries/nextcloud-vue/pull/7036/files

If we have enough similar instances we should probably upstream these changes to the NcModal component, and provide a prop to hide the header there.

Before	After

[julien-nc]

It looks nicer indeed.
I didn't check why yet but: The close button cannot be clicked when the assistant is opened with the smart picker.

[marcoambrosini]

The close button cannot be clicked when the assistant is opened with the smart picker.

I have no way to test this yet because I don't have any model setup so I don't see these actions. Is it a regression from this pr @julien-nc?

[julien-nc]

You can enable the "testing" app which contains some providers.

Yes it is a regression. The close button can be clicked when building the main branch.

[marcoambrosini]

Hmm, the reason is that the modal header div overlays the button, blocking it

I don't know why the header is still there though. Is the modal mounted elsewhere when invoking it from the smart picker @julien-nc ?

[julien-nc]

Yes it's mounted inside the smart picker modal (which contains nothing, it's a trick) to make sure it is displayed on top of it.

[marcoambrosini]

Oh, so that's the header of the smart picker modal :)

[julien-nc]

On which the assistant has no control 😞

[marcoambrosini]

Here you go @julien-nc, could you test with this? https://github.com/nextcloud-libraries/nextcloud-vue/pull/7036/files

[julien-nc]

The combination of this and the change in nextcloud/vue works fine. Thanks