Skip to content

Conversation

julien-nc
Copy link
Member

It was much longer than expected. There's a lot of things to adjust.

  • prop.sync -> v-model:prop
  • many components now take their value as modelValue
  • fixed an issue when creating a new message in the chattyUI, it crashed because the sources attribute was not defined in the new message
  • fixed bug when trying to preserve the "input" field when its type is not "text"
  • fixed admin settings initial state: provide the default system prompts if they are empty
  • I couldn't find a way to change prop values from the outside (in assistant.js) so we now use data props. We just set the initial values with props when creating the vue app. We can then change data prop values with the root component instance 😩
  • view.$destroy() -> app.unmount()
  • We can't catch events from outside Vue anymore. So we fire classic events from the modal element and catch them with elem.addEventListener()
  • NcButton type prop is now variant
  • syntax rules for :deep have changed
  • replace vue-clipboard2 by navigator.clipboard.writeText()

I checked:

  • submitting
  • polling
  • loading a task from the history
  • opening a task's results from a notification
  • smart picker
  • text integration
  • opening an output file with the viewer

It would be nice to play around and try everything. For example the agency feature.

@julien-nc julien-nc requested review from edward-ly and janepie June 12, 2025 12:26
@julien-nc julien-nc added enhancement New feature or request 3. to review labels Jun 12, 2025
@janepie
Copy link
Member

janepie commented Jun 16, 2025

Oooh nice, that's a bunch of work!

I'm playing around a bit and just logging whatever I find, no idea if these are new issues or have been there before :D

  • The action confirmation thingie doesn't respect chosen colors completely, which looks a bit weird

image

  • Dropdown menus don't work properly, I cannot choose anything
  • 'Run task in the background and get notified' button doesn't work

@julien-nc
Copy link
Member Author

The action confirmation thingie doesn't respect chosen colors completely, which looks a bit weird

Hmmm try with the main branch. It looks exactly the same for me in main and enh/noid/vue3:

image

The note card is blue, that does not change with the theming options. The buttons follow theming and Agency actions has background-color: var(--color-primary-element-light-hover);. It's all intended. Do you have suggestions to improve this? Let's do it in another PR though.

Dropdown menus don't work properly, I cannot choose anything

Done, thanks. Some NcCheckbox were not working as well. All fixed.

Run task in the background and get notified' button doesn't work

And "Cancel" didn't work either. Bother are fixed.

@julien-nc
Copy link
Member Author

Thanks for the review 🙏

@janepie
Copy link
Member

janepie commented Jun 17, 2025

Will open a new issue on the note card color :)

Two more things: when choosing a file for Transcribe audio

  • from my device: when I press Cancel, the Assistant modal closes
  • from Nextcloud: the modal behaves weird and has a weird sizing

@julien-nc
Copy link
Member Author

Will open a new issue on the note card color :)

Thanks.

Two more things: when choosing a file for Transcribe audio

Both are fixed. Thanks!

@janepie
Copy link
Member

janepie commented Jun 17, 2025

Okay, we're getting into the weird stuff now (sorry for being so picky): If I use Select from Nextcloud, click a file, then click it again, it stays highlighted but if I click Choose there is an error no file selected

@janepie
Copy link
Member

janepie commented Jun 17, 2025

Okay, just checked, that part is also happening on main, so we can ignore it for now (and I guess it's not on our side). But the Choose button lost its color

before
image

after
image

Copy link
Member

@janepie janepie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@julien-nc julien-nc force-pushed the enh/noid/vue3 branch 3 times, most recently from d31369f to c727547 Compare June 26, 2025 09:04
@julien-nc
Copy link
Member Author

Hey, I rebased on main and solved a lot of conflicts. Could you check again that everything is working?

@julien-nc
Copy link
Member Author

One more fix: the can-close prop of NcModal became no-close.

Copy link
Member

@janepie janepie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
… pickers

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…s deleted

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
Copy link
Member Author

I spotted an extra issue (not related with Vue 3):
When the currently selected task is deleted (via the history entry context menu), the form is not updated so:

  • If the task is scheduled/running: The loading screen stays and we keep polling the task state
  • If the task is done/canceled/anything else: The form keeps showing the task result

Solution: When the task is actually deleted (in <TaskList>), let the upper context know (emit event caught by <AssistantTextProcessingForm>) and create a new task (simulate a click on "new task") so the form is cleared and we stop polling.

I'll make more checks and merge that soon.

@julien-nc julien-nc merged commit 7957474 into main Jun 30, 2025
16 checks passed
@julien-nc julien-nc deleted the enh/noid/vue3 branch June 30, 2025 10:41
@janepie janepie mentioned this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants