-
Notifications
You must be signed in to change notification settings - Fork 18
Migrate to Vue 3 and nextcloud/vue 9 #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oooh nice, that's a bunch of work! I'm playing around a bit and just logging whatever I find, no idea if these are new issues or have been there before :D
|
Hmmm try with the main branch. It looks exactly the same for me in The note card is blue, that does not change with the theming options. The buttons follow theming and Agency actions has
Done, thanks. Some NcCheckbox were not working as well. All fixed.
And "Cancel" didn't work either. Bother are fixed. |
Thanks for the review 🙏 |
Will open a new issue on the note card color :) Two more things: when choosing a file for Transcribe audio
|
Thanks.
Both are fixed. Thanks! |
Okay, we're getting into the weird stuff now (sorry for being so picky): If I use Select from Nextcloud, click a file, then click it again, it stays highlighted but if I click Choose there is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
d31369f
to
c727547
Compare
Hey, I rebased on main and solved a lot of conflicts. Could you check again that everything is working? |
One more fix: the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
… pickers Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…s deleted Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
I spotted an extra issue (not related with Vue 3):
Solution: When the task is actually deleted (in I'll make more checks and merge that soon. |
It was much longer than expected. There's a lot of things to adjust.
prop.sync
->v-model:prop
modelValue
view.$destroy()
->app.unmount()
elem.addEventListener()
type
prop is nowvariant
:deep
have changednavigator.clipboard.writeText()
I checked:
It would be nice to play around and try everything. For example the agency feature.