Use outline icons where it makes sense #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SendIcon to SendOutlinedIcon? |
|
also ShareVariantIcon to ShareVariantOutlineIcon, maybe |
|
SendOutlinedIcon looks bad, the normal one is not so "thick". I think that's ok. |
|
That's fine. How about:
|
julien-nc
force-pushed
the
enh/noid/icons
branch
from
2d66685 to
816460f
Compare
|
@edward-ly Yep, done, thanks. |
julien-nc
force-pushed
the
enh/noid/icons
branch
from
816460f to
0dbbc45
Compare
kyteinsky
reviewed
Jun 30, 2025
There was a problem hiding this comment.
Not really related to vue 3 migration but it could be a good place to fix this. It happens when the text contains large texts that cannot be wrapped on spaces like long URLs. The browser window has been shrunk horizontally too.
These seem like vue 3 regression/prop change.
- User status is disabled so should not be displayed for "admin". The new prop is
hideStatus. - Assistant icon is not centered
… material ones Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…the chat Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/icons
branch
from
d9eb9cc to
783c6a9
Compare
|
@kyteinsky Thanks. I think both those issues are now fixed (with the last 2 commits). |
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And replace custom icons by material ones.