Skip to content

Conversation

lukasdotcom
Copy link
Member

@lukasdotcom lukasdotcom commented Jul 14, 2025

Resolves: #299
Resolves: #300
Resolves: #301
image

Some design questions.

  1. For some reason the waveform icon is different in the vue material icons than on the material icons (or I couldn't find it🤷) so had to upload the icon from google fonts. The one that vue material icons comes with is: image

  2. I'm not sure if context chat should have its own category, but left it in text (can be moved to other). EDIT: Added category for context chat with icon that was discussed with @marcoambrosini

  3. I changed the maximum width to 1220px instead of 1200px to ensure that all categories can fit on one line in english.

Other notes.

  1. The rules to assign categories are built to be flexible and guess categories for new tasks as long as they follow some implied rules.
  2. I did remove the inline menu, but theoretically could add the old one back just doesn't work well with categories.
  3. Also added convenience feature that if only one task exists in category clicking on the category will bring you to that task.

@marcelklehr
Copy link
Member

I'd be in favor of moving context chat out of the Working with text category

@marcelklehr
Copy link
Member

Looks really nice :)

@lukasdotcom
Copy link
Member Author

lukasdotcom commented Jul 14, 2025

I'd be in favor of moving context chat out of the Working with text category

Personally I would be too. I just followed the design that was given for now.

@lukasdotcom
Copy link
Member Author

lukasdotcom commented Jul 15, 2025

The last commit, f938c09, added an overflow menu that allows you to select categories and tasks when there are too many. Note that the amount of inlined tasks needs to be specified as a prop currently.
image

@lukasdotcom lukasdotcom force-pushed the feat/categories branch 2 times, most recently from 8c1db02 to f938c09 Compare July 15, 2025 20:52
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
I hope you don't mind, I made a change to use a "large" modal (instead of full) and make it larger so it looks better IMO.
I also adjusted the width of the UI in the standalone assistant page (/apps/assistant).

I'll have a look at the code.

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of nitpicking 😁
Also, could we prevent opening the actions dropdown when clicking on a category in which there is only one task type? Maybe we should only do that when the category name equals the single task type name. It's the case for translate and chat with AI.

@julien-nc
Copy link
Member

Also, I would recommend to rebase on main from time to time. A small conflict is better than a big conflict 😁

lukasdotcom and others added 7 commits July 17, 2025 09:47
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
…rge size and make it larger instead of using full size

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ot needed

Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
@lukasdotcom
Copy link
Member Author

A bit of nitpicking 😁 Also, could we prevent opening the actions dropdown when clicking on a category in which there is only one task type? Maybe we should only do that when the category name equals the single task type name. It's the case for translate and chat with AI.

I changed it to create a NcButton when there is no dropdown needed because I couldn't find a way to hide it and implemented the other minor name changes.

@lukasdotcom lukasdotcom requested a review from julien-nc July 17, 2025 13:50
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasdotcom lukasdotcom merged commit 08f247e into main Jul 18, 2025
9 checks passed
@lukasdotcom lukasdotcom deleted the feat/categories branch July 18, 2025 12:48
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good @lukasdotcom! :) It will help people a lot to have a better overview

@janepie janepie mentioned this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce total amount of width of the assistant Add descriptive icons to the assistant tabs Simplify and group Assistant tabs
4 participants