-
Notifications
You must be signed in to change notification settings - Fork 17
feat: Add categories with icons #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd be in favor of moving context chat out of the Working with text category |
Looks really nice :) |
Personally I would be too. I just followed the design that was given for now. |
1f88275
to
938fb38
Compare
The last commit, f938c09, added an overflow menu that allows you to select categories and tasks when there are too many. Note that the amount of inlined tasks needs to be specified as a prop currently. |
8c1db02
to
f938c09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
I hope you don't mind, I made a change to use a "large" modal (instead of full) and make it larger so it looks better IMO.
I also adjusted the width of the UI in the standalone assistant page (/apps/assistant).
I'll have a look at the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of nitpicking 😁
Also, could we prevent opening the actions dropdown when clicking on a category in which there is only one task type? Maybe we should only do that when the category name equals the single task type name. It's the case for translate and chat with AI.
Also, I would recommend to rebase on main from time to time. A small conflict is better than a big conflict 😁 |
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
…rge size and make it larger instead of using full size Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ot needed Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
0ca5b09
to
8f34380
Compare
I changed it to create a NcButton when there is no dropdown needed because I couldn't find a way to hide it and implemented the other minor name changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good @lukasdotcom! :) It will help people a lot to have a better overview
Resolves: #299

Resolves: #300
Resolves: #301
Some design questions.
For some reason the waveform icon is different in the vue material icons than on the material icons (or I couldn't find it🤷) so had to upload the icon from google fonts. The one that vue material icons comes with is:
I'm not sure if context chat should have its own category, but left it in text (can be moved to other). EDIT: Added category for context chat with icon that was discussed with @marcoambrosini
I changed the maximum width to 1220px instead of 1200px to ensure that all categories can fit on one line in english.
Other notes.