Use new assistant theme #349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #347
If we want to keep supporting NC 30 and 31, we need to be careful with this custom style that is not included in NC < 32. There is now a
use-modern-style
initial state injected to decide if we use the new css vars or not.@marcoambrosini We can't use
NcAssistantButton
becauseNcButton
in some places, this component does not allow to use a custom icon so we're stuck with the assistant one but we want the category oneSo I went with custom styling using the css variables.

I tried to replicate the gradient in the NcAssistantButton component but this is done by using a gradient background in an element wrapping the NcButton. Here we directly use the button, no wrapping element. I couldn't find a way to have this gradient border so I removed the border which IMHO looks better than the border gradient + a different button gradient.
This is how NcAssistantButton look like with the 2 gradients: