Skip to content

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Sep 3, 2025

closes #347

  • Adjust header menu icon: use NcHeaderButton (that comes with a transparency gradient)
image
  • Adjust the main form title (icon + text color)
  • Change selected task type category style
image image

If we want to keep supporting NC 30 and 31, we need to be careful with this custom style that is not included in NC < 32. There is now a use-modern-style initial state injected to decide if we use the new css vars or not.

@marcoambrosini We can't use NcAssistantButton because

  • NcActions is not flexible enough
  • Even if we could use it to replace our NcButton in some places, this component does not allow to use a custom icon so we're stuck with the assistant one but we want the category one

So I went with custom styling using the css variables.
I tried to replicate the gradient in the NcAssistantButton component but this is done by using a gradient background in an element wrapping the NcButton. Here we directly use the button, no wrapping element. I couldn't find a way to have this gradient border so I removed the border which IMHO looks better than the border gradient + a different button gradient.
This is how NcAssistantButton look like with the 2 gradients:
image

@julien-nc julien-nc added enhancement New feature or request 3. to review labels Sep 3, 2025
@julien-nc julien-nc marked this pull request as ready for review September 3, 2025 13:35
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to at least add a solid border for now?

@julien-nc
Copy link
Member Author

With classic border and color being #40519A:
image

@marcelklehr
Copy link
Member

🎉

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/347/assistant-style-and-new-components branch from e11aeba to f44efa7 Compare September 5, 2025 07:56
@julien-nc julien-nc merged commit d232253 into main Sep 5, 2025
16 checks passed
@julien-nc julien-nc deleted the enh/347/assistant-style-and-new-components branch September 5, 2025 07:58
@julien-nc julien-nc mentioned this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update assistant theme
3 participants