Skip to content

Commit 0d19a13

Browse files
Merge pull request #52443 from nextcloud/reminder-dont-validiate-node-dav
fix: don't check node access again for listing reminders in dav
2 parents 1cb1f39 + 3d36625 commit 0d19a13

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

apps/files_reminders/lib/Dav/PropFindPlugin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ function () use ($node) {
6262
}
6363

6464
$fileId = $node->getId();
65-
$reminder = $this->reminderService->getDueForUser($user, $fileId);
65+
$reminder = $this->reminderService->getDueForUser($user, $fileId, false);
6666
if ($reminder === null) {
6767
return '';
6868
}

apps/files_reminders/lib/Service/ReminderService.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,10 @@ public function cacheFolder(IUser $user, Folder $folder): void {
6464
/**
6565
* @throws NodeNotFoundException
6666
*/
67-
public function getDueForUser(IUser $user, int $fileId): ?RichReminder {
68-
$this->checkNode($user, $fileId);
67+
public function getDueForUser(IUser $user, int $fileId, bool $checkNode = true): ?RichReminder {
68+
if ($checkNode) {
69+
$this->checkNode($user, $fileId);
70+
}
6971
/** @var null|false|Reminder $cachedReminder */
7072
$cachedReminder = $this->cache->get("{$user->getUID()}-$fileId");
7173
if ($cachedReminder === false) {

0 commit comments

Comments
 (0)