Skip to content

fix(caldav): use direct.edit route in event activities #52410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Apr 24, 2025

  • Resolves: none

Summary

There is no reason to force a view and timerange here. We can just use the simplified direct route as the object id is the only thing known in the activity.

['name' => 'view#index', 'url' => '/edit/{objectId}', 'verb' => 'GET', 'postfix' => 'direct.edit'],

Checklist

@st3iny st3iny added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Apr 24, 2025
@st3iny st3iny added this to the Nextcloud 32 milestone Apr 24, 2025
@st3iny st3iny self-assigned this Apr 24, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Apr 24, 2025
@tcitworld
Copy link
Member

Checkout nodb tests though

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/caldav/use-direct-route-event-activity branch from 1ded873 to cf319ae Compare April 25, 2025 18:35
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish feature: activity and notification and removed 3. to review Waiting for reviews labels Apr 25, 2025
@st3iny st3iny enabled auto-merge April 25, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: activity and notification feature: caldav Related to CalDAV internals
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

3 participants