Skip to content

fix(settings): only provide groups the subadmin has access to #52417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2025
Merged

fix(settings): only provide groups the subadmin has access to #52417

merged 3 commits into from
Apr 27, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 24, 2025 •
edited
Loading

Summary

The group endpoints do not allow to search for users if the user is a subadmin.
So we need to already provide the full list of groups on page load.

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Apr 24, 2025
@susnux susnux requested review from a team as code owners April 24, 2025 12:27
@susnux susnux requested review from nfebe, skjnldsv, szaimen and provokateurin and removed request for a team April 24, 2025 12:27
@susnux
Copy link
Contributor Author

susnux commented Apr 24, 2025

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Apr 24, 2025

/backport to stable31

provokateurin
provokateurin requested changes Apr 24, 2025
View reviewed changes
@szaimen szaimen removed their request for review April 24, 2025 13:07
susnux
susnux commented Apr 24, 2025
View reviewed changes
@susnux susnux requested a review from provokateurin April 24, 2025 13:14
provokateurin
provokateurin approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM

skjnldsv
skjnldsv reviewed Apr 25, 2025
View reviewed changes
@susnux susnux force-pushed the fix/group-admin-new-user branch 3 times, most recently from 2bd496f to 3eda00b Compare April 25, 2025 14:30
@joshtrichards
Copy link
Member

Related: #52383

susnux added 3 commits April 27, 2025 11:35
@susnux
feat(settings): provide user groups for accounts list
8cc0c26 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(settings): group admins only can add users to their groups
6d8c49f 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
1ba88da 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/group-admin-new-user branch from 3eda00b to 1ba88da Compare April 27, 2025 09:38
@susnux susnux merged commit e229102 into master Apr 27, 2025
190 of 193 checks passed
@susnux susnux deleted the fix/group-admin-new-user branch April 27, 2025 10:39
This was referenced Apr 27, 2025
Merged
Merged
@susnux susnux mentioned this pull request Apr 29, 2025
Open
8 tasks
@solracsf solracsf mentioned this pull request May 3, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin provokateurin approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: settings
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

[Bug]: Group Admins are not able to create new Accounts after Upgrade to 30.0.9
4 participants
@susnux @joshtrichards @skjnldsv @provokateurin