Migrate editor instantiation to setup function #7371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7371 +/- ##
==========================================
- Coverage 59.65% 59.65% -0.01%
==========================================
Files 486 486
Lines 37288 37286 -2
Branches 1097 1097
==========================================
- Hits 22245 22243 -2
Misses 14937 14937
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
force-pushed
the
migrate/editor-to-setup-function
branch
3 times, most recently
from
55ce342 to
2b7dc03
Compare
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Move its definition into the setup function. One problem that becomes apparent here - but that we probably already have: On a reconnect the provider will change. But it remains the same in the collaboration cursor extension effectively disconnecting the two. Signed-off-by: Max <max@nextcloud.com>
Keep the same awareness state - even when a new provider instance is created - for example on reconnect. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
migrate/editor-to-setup-function
branch
from
2b7dc03 to
4a49f73
Compare
max-nextcloud
changed the title
mejo-
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Great to see the issue with syncService in CollaborationCursor after reconnect being resolved and editor creation being moved to the setup function ❤️
What is missing to remove all the editor === null handling (i.e. this.editor?.something)? In any case, ready to get merged from my side 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7313.
Move sync service and sync service provider into the setup function
so we can also initialize the editor there right away.