Implement ISetDisplayNameBackend in the user backend #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
julien-nc
force-pushed
the
fix/965/provisioning-display-name
branch
3 times, most recently
from
b6ba87f to
84faf55
Compare
julien-nc
force-pushed
the
fix/965/provisioning-display-name
branch
from
84faf55 to
382a366
Compare
…ect photo in system addressbook vcard and simplifies the provisioning service Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/965/provisioning-display-name
branch
from
382a366 to
1008f61
Compare
juliusknorr
reviewed
Mar 10, 2025
| use Psr\Log\LoggerInterface; | ||
|
|
||
| class Backend extends ABackend implements IPasswordConfirmationBackend, IGetDisplayNameBackend, IApacheBackend, ICustomLogout, ICountUsersBackend { | ||
| class Backend extends ABackend implements IPasswordConfirmationBackend, IGetDisplayNameBackend, ISetDisplayNameBackend, IApacheBackend, ICustomLogout, ICountUsersBackend { |
There was a problem hiding this comment.
This would mean that users can change the displayname also trough the Nextcloud profile page, no?
Since the IdP has authority over the display name that is used, we should not implement this interface I think.
There was a problem hiding this comment.
Can confirm that displayName can be changed trough the Nextcloud profile page when this is implemented (manually patched NC v30.0.10 with App v7.2.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #965
This fixes incorrect photo in system addressbook vcard (it was always an avatar based on the previous display name or the user ID for new users).
The server apparently behaves differently if the user backend is a ISetDisplayNameBackend one or not.
This change also simplifies the provisioning service.
To reproduce the initial issue:
aaafor example, a first name ofJaneand a last name ofDoeJane Doecontact's photo is just anA. It should beJD.Zenon the IdP sideJDand should beZD