Skip to content

Commit 6753aaf

Browse files
authored
Merge pull request nextcloud#41035 from nextcloud/fix/37092/apps-list--html-validation
fix(settings): apps list html validation and loading icon
2 parents 7a55ea7 + 7e94468 commit 6753aaf

File tree

6 files changed

+16
-14
lines changed

6 files changed

+16
-14
lines changed

apps/settings/src/components/AppList/AppItem.vue

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
class="app-icon" />
4545
</svg>
4646

47-
<img v-if="!listView && app.screenshot && screenshotLoaded" :src="app.screenshot" width="100%">
47+
<img v-if="!listView && app.screenshot && screenshotLoaded" :src="app.screenshot" alt="">
4848
</component>
4949
<component :is="dataItemTag"
5050
class="app-name"
@@ -210,7 +210,11 @@ export default {
210210
</script>
211211

212212
<style scoped lang="scss">
213-
.app-icon {
214-
filter: var(--background-invert-if-bright);
215-
}
213+
.app-icon {
214+
filter: var(--background-invert-if-bright);
215+
}
216+
217+
.app-image img {
218+
width: 100%;
219+
}
216220
</style>

apps/settings/src/views/Apps.vue

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,9 @@
2222

2323
<template>
2424
<NcContent app-name="settings"
25-
:class="{ 'with-app-sidebar': app}"
26-
:content-class="{ 'icon-loading': loadingList }"
27-
:navigation-class="{ 'icon-loading': loading }">
25+
:class="{ 'with-app-sidebar': app}">
2826
<!-- Categories & filters -->
29-
<NcAppNavigation>
27+
<NcAppNavigation :class="{ 'icon-loading': loading }">
3028
<template #list>
3129
<NcAppNavigationItem id="app-category-your-apps"
3230
:to="{ name: 'apps' }"

dist/settings-apps-view-7418.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-apps-view-7418.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-vue-settings-apps-users-management.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-vue-settings-apps-users-management.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)