XIOS implementation of writeDiagnosticTime
#934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XIOS implementation of
writeDiagnosticTime
Fixes #917
Merges into #928
Will be followed by addressing #929
Task List
Change Description
This PR provides an XIOS implementation of
writeDiagnosticTime
. It completes the set of member functions needed inParaGridIO_Xios
, so the other copied functions are deleted andifdef
-ed out in the header.Much like in #928, this required a new config section
XiosDiagnostic
(c.f.XiosForcing
).During my work on this, I noticed #933 and #935.
Test Description
Changes to XIOS read test for consistency.
Documentation Impact
Diagnostics are mentioned in the XIOS section of the docs.
Pre-Request Checklist