-
Notifications
You must be signed in to change notification settings - Fork 19
Reuse time metadata config in XIOS #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-start-stop-take2_merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could use metadata.runLength()
in one place, but otherwise this looks good.
core/src/Xios.cpp
Outdated
if (periodStr.length() == 0 || periodStr == "0") { | ||
setFileOutputFreq(fileId, stopTime - startTime); | ||
ModelMetadata& metadata = ModelMetadata::getInstance(); | ||
setFileOutputFreq(fileId, metadata.stopTime() - metadata.startTime()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't metadata.runLength()
exactly metadata.stopTime() - metadata.startTime()
? (It should be)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks @timspainNERSC. Addressed in 326c552.
Use model config in XIOS
Fixes #925
Follows #936
Second attempt following #932
Merges into #913Task List
Change Description
This PR reuses the time metadata set as part of the config set in the XIOS handler.
Test Description
For the purposes of testing, a separate
Model.configureTime
member function is created to avoid having to configure everything. I also needed to get the build system to create partition metadata files for 1 and 3 MPI ranks for the XIOS tests and to extend the configuration for all of them.Documentation Impact
The XIOS doc pages are updated to reflect these changes.
Pre-Request Checklist