Skip to content

Commit 11ded3d

Browse files
authored
Merge pull request #420 from JoseEspinosa/updates
Fix how replicates are set for downstream analysis
2 parents dd37833 + a950571 commit 11ded3d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6-
## [[2.1.0](https://github.com/nf-core/chipseq/releases/tag/2.1.0)] - 2024-10-02
6+
## [[2.1.0](https://github.com/nf-core/chipseq/releases/tag/2.1.0)] - 2024-10-07
77

88
### Credits
99

@@ -48,6 +48,7 @@ Thank you to everyone else that has contributed by reporting bugs, enhancements
4848
- [[PR #406](https://github.com/nf-core/chipseq/pull/406)] - Update metro map to show macs3 instead of macs2.
4949
- [[#409](https://github.com/nf-core/chipseq/issues/409)] - Bulk modules and subworkflows update.
5050
- [[PR #415](https://github.com/nf-core/chipseq/pull/415)] - Get rid of `oras` in modules.
51+
- [[PR #420](https://github.com/nf-core/chipseq/pull/420)] - Fix bug on how replicates are set for MACS3 downstream analysis.
5152

5253
### Parameters
5354

subworkflows/local/bed_consensus_quantify_qc_bedtools_featurecounts_deseq2.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ workflow BED_CONSENSUS_QUANTIFY_QC_BEDTOOLS_FEATURECOUNTS_DESEQ2 {
3030
ch_peaks
3131
.map {
3232
meta, peak ->
33-
[ meta.antibody, meta.id - ~/_T\d+$/, peak ]
33+
[ meta.antibody, meta.id - ~/_REP\d+$/, peak ]
3434
}
3535
.groupTuple()
3636
.map {
@@ -46,7 +46,7 @@ workflow BED_CONSENSUS_QUANTIFY_QC_BEDTOOLS_FEATURECOUNTS_DESEQ2 {
4646
def meta_new = [:]
4747
meta_new.id = antibody
4848
meta_new.multiple_groups = groups.size() > 1
49-
meta_new.replicates_exist = groups.max { groups.value }.value > 1
49+
meta_new.replicates_exist = groups.max { it.value }.value > 1
5050
[ meta_new, peaks ]
5151
}
5252
.set { ch_antibody_peaks }

0 commit comments

Comments
 (0)