Skip to content

Update tests bwameth/index#11187

Merged
LouisLeNezet merged 1 commit intonf-core:masterfrom
LouisLeNezet:bwameth/index
Apr 15, 2026
Merged

Update tests bwameth/index#11187
LouisLeNezet merged 1 commit intonf-core:masterfrom
LouisLeNezet:bwameth/index

Conversation

@LouisLeNezet
Copy link
Copy Markdown
Contributor

PR checklist

Closes #10471

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this Apr 14, 2026
Copy link
Copy Markdown
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you updating this? Just to use sanitizeOutput?

@LouisLeNezet
Copy link
Copy Markdown
Contributor Author

The issue was not closed, so I started to work on it to figure out later that it was done in an unlinked PR.
As I've already updated the other bwameth module, I decided to uniformize the two modules 😄

@LouisLeNezet LouisLeNezet added this pull request to the merge queue Apr 15, 2026
Merged via the queue into nf-core:master with commit 1f61348 Apr 15, 2026
63 checks passed
@LouisLeNezet LouisLeNezet deleted the bwameth/index branch April 15, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration to topic channels: bwameth/index

2 participants