-
Notifications
You must be signed in to change notification settings - Fork 37
Added optional Bwa index parameter to skip bwamem2 index for a faster output #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c7867ab
Added bwa_index parameter
b8b638f
updated process paramters for modules
16cad1b
added citations and updated snapshots
agrima2010 f96e208
prettier and linting
agrima2010 c11a49d
linting
agrima2010 567a431
linting
agrima2010 8a20d2d
config files updated
agrima2010 d5ae511
linting
agrima2010 6417907
linting
agrima2010 257ff2d
minor changes
agrima2010 8527ccd
Merge branch 'dev' into bwa_index
maxulysse d23962a
Update nextflow_schema.json
maxulysse 5eeac1a
Merge branch 'dev' into bwa_index
maxulysse 2b6c91d
fix snapshots
maxulysse 3aef3c6
Merge branch 'dev' into bwa_index
maxulysse 2649b29
Update CHANGELOG.md
maxulysse db1437e
solve merge conflicts
maxulysse 7855613
removed hasta config and corrected nextflow_schema.json
agrima2010 b7cbd8e
nextflow_schema.json
agrima2010 457e19b
nextflow.config
agrima2010 df0f9c0
removed channel output of BAM from seqinspector.nf
agrima2010 16f508a
bwa_index added to nextflow.config
agrima2010 e8ac39a
Update nextflow_schema.json
agrima2010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ params { | |
| igenomes_base = 's3://ngi-igenomes/igenomes/' | ||
| igenomes_ignore = false | ||
| sort_bam = true | ||
| bwa_index = null | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that should not be needed |
||
|
|
||
| // Fastqscreen options | ||
| fastq_screen_references = "${projectDir}/assets/example_fastq_screen_references.csv" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -214,7 +214,8 @@ | |
| "modules_testdata_base_path": { | ||
| "type": "string", | ||
| "description": "Base path / URL for data used in the modules", | ||
| "hidden": true | ||
| "hidden": true, | ||
| "default": "s3://ngi-igenomes/testdata/nf-core/modules/" | ||
| }, | ||
| "multiqc_config": { | ||
| "type": "string", | ||
|
|
@@ -282,5 +283,10 @@ | |
| { | ||
| "$ref": "#/$defs/generic_options" | ||
| } | ||
| ] | ||
| ], | ||
| "properties": { | ||
| "bwa_index": { | ||
| "type": "string" | ||
| } | ||
| } | ||
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so for me bwa and other indexes should be fetch using getGenomeAttribute at this level from the igenomes.config file around L17