Skip to content

Preserve the value of self.modules_repo across nested calls #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
Merged

Preserve the value of self.modules_repo across nested calls #3881

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4be08d
Preserve the value of self.modules_repo across nested calls
muffato Nov 7, 2025
fb80c7d
[automated] Update CHANGELOG.md
nf-core-bot Nov 7, 2025
6caa62e
Added a test
muffato Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
### Modules

- Add `topics` to the template + update linting ([#3779](https://github.com/nf-core/tools/pull/3779))
- Preserve the value of self.modules_repo across nested calls ([#3881](https://github.com/nf-core/tools/pull/3881))

### Subworkflows

Expand Down
3 changes: 3 additions & 0 deletions nf_core/components/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ def install_included_components(self, subworkflow_dir):
"""
Install included modules and subworkflows
"""
ini_modules_repo = self.modules_repo
modules_to_install, subworkflows_to_install = get_components_to_install(subworkflow_dir)
for s_install in subworkflows_to_install:
original_installed = self.installed_by
Expand All @@ -208,6 +209,8 @@ def install_included_components(self, subworkflow_dir):
self.install(m_install, silent=True)
self.component_type = original_component_type
self.installed_by = original_installed
# self.install will have modified self.modules_repo. Restore its original value
self.modules_repo = ini_modules_repo

def collect_and_verify_name(
self, component: str | None, modules_repo: "nf_core.modules.modules_repo.ModulesRepo"
Expand Down