Skip to content

HorizontalPodAutoscaler Support #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mpstefan opened this issue Jun 4, 2025 · 2 comments · May be fixed by #3492
Open

HorizontalPodAutoscaler Support #3447

mpstefan opened this issue Jun 4, 2025 · 2 comments · May be fixed by #3492
Labels
community enhancement New feature or request highlight Relates to features that should be promoted despite not being an epic
Milestone
v2.2.0

Comments

@mpstefan
Copy link
Member

mpstefan commented Jun 4, 2025 •
edited by sindhushiv
Loading

As a cluster operator using NGF
I want NGF to work with a HorizontalPodAutoscaler
So that I can automate the scaling of my data planes to save on resources and scale up when traffic increases.

NIC PR: nginx/kubernetes-ingress#3276

Acceptance

  • (Needs refinement) The user can setup a HorizontalPodAutoscaler for an NGINX deployment and it will work with the NGF control plane.
@mpstefan mpstefan converted this from a draft issue Jun 4, 2025
@mpstefan mpstefan added enhancement New feature or request community labels Jun 4, 2025
@mpstefan mpstefan added this to the v2.2.0 milestone Jun 4, 2025
@mpstefan mpstefan added the highlight Relates to features that should be promoted despite not being an epic label Jun 4, 2025
@mpstefan
Copy link
Member Author

mpstefan commented Jun 4, 2025

Original discussion issue: #3440

@nowjean Moved your original question to be tracked in this issue. Thanks for the feedback!

@mpstefan mpstefan mentioned this issue Jun 4, 2025
Closed
@nowjean nowjean linked a pull request Jun 11, 2025 that will close this issue
Open
6 tasks
@nowjean
Copy link

nowjean commented Jun 12, 2025

@mpstefan Thank! I'm using NGF2.0. For HPA, Do I have to apply hpa to control plane(ngf-nginx-gateway-fabric) or data plane(practice-gateway-nginx) or both of them?

nowjean pushed a commit to nowjean/nginx-gateway-fabric that referenced this issue Jun 14, 2025
@renovate @nowjean
Update dependency goreleaser/goreleaser to v2.10.2 (nginx#3478)
b4ada1b 
| datasource  | package               | from   | to      |
| ----------- | --------------------- | ------ | ------- |
| github-tags | goreleaser/goreleaser | v2.9.0 | v2.10.2 |

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add Nginx Gateway HPA(nginx#3447)
nowjean pushed a commit to nowjean/nginx-gateway-fabric that referenced this issue Jun 14, 2025
@sjberman @nowjean
Fix index out of bounds error when building status (nginx#3513)
96bfecc 
Problem: There's a specific scenario where we can hit an out of bounds index while building route statuses. I don't know the exact scenario, but it involves a parentRef without a sectionName, on a Gateway with a single listener. Could possibly involve having multiple implementations being deployed as well.

Solution: Adjust the logic to ensure we don't access indices that are out of bounds.

Add Nginx Gateway HPA(nginx#3447)
nowjean added a commit to nowjean/nginx-gateway-fabric that referenced this issue Jun 14, 2025
@nowjean
Add Nginx Gateway HPA(nginx#3447)
365bcb7
nowjean pushed a commit to nowjean/nginx-gateway-fabric that referenced this issue Jun 14, 2025
@sjberman @nowjean
Fix index out of bounds error when building status (nginx#3513)
14aa9c6 
Problem: There's a specific scenario where we can hit an out of bounds index while building route statuses. I don't know the exact scenario, but it involves a parentRef without a sectionName, on a Gateway with a single listener. Could possibly involve having multiple implementations being deployed as well.

Solution: Adjust the logic to ensure we don't access indices that are out of bounds.

ADD Nginx Gateway HPA(nginx#3447)
nowjean pushed a commit to nowjean/nginx-gateway-fabric that referenced this issue Jun 14, 2025
@renovate @nowjean
Update dependency goreleaser/goreleaser to v2.10.2 (nginx#3478)
1a40c74 
| datasource  | package               | from   | to      |
| ----------- | --------------------- | ------ | ------- |
| github-tags | goreleaser/goreleaser | v2.9.0 | v2.10.2 |

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

ADD Nginx Gateway HPA(nginx#3447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community enhancement New feature or request highlight Relates to features that should be promoted despite not being an epic
Projects
NGINX Gateway Fabric
Status: 🆕 New
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Hpa nowjean/nginx-gateway-fabric
2 participants
@mpstefan @nowjean