Skip to content

docker-entrypoint logs do not account for S3_STYLE #367

Open
@SuperCoolAlan

Description

@SuperCoolAlan

Describe the bug

Logs generated at https://github.com/nginxinc/nginx-s3-gateway/blob/main/common/docker-entrypoint.d/00-check-for-required-env.sh#L127 do not accurately reflect the server path used during runtime. This is quite misleading on first glance. Program logic accounts for S3_STYLE https://github.com/nginxinc/nginx-s3-gateway/blob/main/common/docker-entrypoint.sh#L86-L95 and seems to set the address correctly for nginx, but this does not match the logs I mentioned above.

To reproduce

Steps to reproduce the behavior:

  1. Start container with env var S3_STYLE set to "path" and S3_BUCKET_NAME set to "mybucket"
  2. View logs
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/00-check-for-required-env.sh
S3 Backend Environment
Access Key ID: <omitted>
Origin: http://mybucket.service.namespace.svc.cluster.local:9000
  1. See error at line beginning with Origin

Expected behavior

When S3_STYLE is set to "path", the line beginning with Origin should display an origin that does not include the bucket name. ie. http://service.namespace.svc.cluster.local:9000

Your environment

  • Version of the S3 container used: ghcr.io/nginxinc/nginx-s3-gateway/nginx-oss-s3-gateway:latest-20220916
  • Target deployment platform for the S3 container: Kubernetes Talos cluster
  • S3 backend implementation: MinIO hosted on same Kubernetes cluster
  • Authentication method: S3_ACCESS_KEY_ID, S3_SECRET_KEY generated in MinIO instance

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions