Nim integration #159
Open
Nim integration #159
+489
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s) data collection
dareste
requested changes
Jul 7, 2025
cmd/nginx-supportpkg.go
Outdated
| @@ -106,6 +119,9 @@ func Execute() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| rootCmd.Flags().BoolVarP(&excludeDBData, "exclude-db-data", "d", false, "exclude DB data collection") | |||
There was a problem hiding this comment.
Maybe renaming these new flags exclude-db-data and exclude-time-series-data to something that contains the string nim would help the user understand these options apply only to that product.
| @@ -266,3 +269,68 @@ func (c *DataCollector) AllNamespacesExist() bool { | |||
|
|
|||
| return allExist | |||
| } | |||
|
|
|||
| // CopyFileFromPod copies a file from a pod's container to the local filesystem. | |||
| func (c *DataCollector) CopyFileFromPod(namespace, pod, container, srcPath, destPath string, ctx context.Context) error { | |||
There was a problem hiding this comment.
Cant' you just leverage on the PodExecutor function for this? It seems you are duplicating quite a few code.
* Pass DataCollector struct as a reference from main * Improve logic around job result/status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.