Skip to content

Fix hardcoded container name for nic jobs #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix hardcoded container name for nic jobs #67

merged 1 commit into from
Oct 15, 2024

Conversation

dareste
Copy link
Collaborator

@dareste dareste commented Oct 14, 2024

Proposed changes

Fixes #66.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@dareste dareste requested a review from a team as a code owner October 14, 2024 08:20
Copy link
Collaborator

@mrajagopal mrajagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all this, we are assuming that the nginx-ingress pod is called so or contains that string in its name.
So far we have not seen otherwise.
Therefore, assuming so shall suffice for now.
When we encounter a case where the nginx-ingress pod doesn't have it in the name, then we may need to pass argument for the pod name.

@mrajagopal mrajagopal merged commit 32e3da6 into main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"nginx -T" command execution failures
2 participants