Skip to content

chore: pin to KIC helm 0.15.2 / image 2.4.2 due to #225 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Jan 18, 2023

Proposed changes

This is a temp fix for #225 - it pins our NGINX Ingress helm chart to 0.15.2 and our NGINX binary to 2.4.2 if no other value exists in the pulumi configuration for that stack.

This will be reverted once the issues defined in #225 are mitigated.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@qdzlug qdzlug requested a review from 4141done January 18, 2023 01:52
Copy link
Contributor

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my usual comment about the number of places this version number needs to be changed stands but I know we'll be addressing this in larger changes down the line.

@qdzlug qdzlug merged commit 45bf269 into nginxinc:master Jan 18, 2023
@qdzlug qdzlug deleted the kicfix branch January 19, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants