-
Notifications
You must be signed in to change notification settings - Fork 3
Redocly: Add support for content on redocly pages #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mainframe
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
Do we want tiny redocly width? |
Let me see if there's an easy way to expand it beyond our max content grid size 🤔 |
Redocly really needs to be full width. It's really unusable and looks awful when it's letterboxed inside our docs. |
0fe6c05
to
867acb9
Compare
@@ -881,6 +881,26 @@ nav { | |||
[data-grid="half"] { | |||
grid-column: span 6; | |||
} | |||
|
|||
[data-grid="breakout"] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly has to do with position of something in the Cards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue is that if you use it on a non-direct child of the content grid, it will break. Probably should add that comment for future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove side padding, add gray borders top and bottom.
Scrolling hides the Redocly sidebar behind the navbar.
@@ -881,6 +881,26 @@ nav { | |||
[data-grid="half"] { | |||
grid-column: span 6; | |||
} | |||
|
|||
[data-grid="breakout"] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue is that if you use it on a non-direct child of the content grid, it will break. Probably should add that comment for future reference.
867acb9
to
2ae558c
Compare
I know. I can't help myself. More redocly changes.
This removes the concept of a redocly "layout" in hugo, and instead, uses it as a standard partial in our default
single.html
.The main benefit of this is that you can have other content on a page besides redocly.
The frontmatter you need:
This stops the redocly js files loading on every page.
This implementation essentially uses a css
breakout
, to make it spread beyond the grid.It's still using the
data-grid
attribute.Examples across all three types of media queries.