Skip to content

Commit 9595688

Browse files
committed
Merge branch 'develop'
* develop: 0.0.6 fixed layout switching / default layout handling
2 parents dc39594 + 9762eeb commit 9595688

File tree

7 files changed

+24
-22
lines changed

7 files changed

+24
-22
lines changed

demo.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ <h1 class="md-headline">Angular Material Keyboard Demo</h1>
5353
], 'lang': ['de']
5454
});
5555

56-
// default layout is english
56+
// default layout is german
5757
$mdKeyboardProvider.defaultLayout('Deutsch');
5858
})
5959
.controller('keyboardDemoCtrl', function ($scope) {

dist/mdKeyboard.js

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1246,13 +1246,10 @@ function MdKeyboardProvider($$interimElementProvider, keyboardLayouts, keyboardD
12461246

12471247
// set name of layout to use
12481248
function useLayout(layout) {
1249-
if (LAYOUTS[layout]) {
1249+
if (layout && LAYOUTS[layout]) {
12501250
CURRENT_LAYOUT = layout;
1251-
// broadcast new layout
1252-
if (SCOPE) {
1253-
SCOPE.$broadcast('$mdKeyboardLayoutChanged', CURRENT_LAYOUT);
1254-
}
12551251
} else {
1252+
CURRENT_LAYOUT = DEFAULT_LAYOUT;
12561253
if (layout.length) {
12571254
var msg = "" +
12581255
"The keyboard layout '" + layout + "' does not exists. \n" +
@@ -1261,6 +1258,10 @@ function MdKeyboardProvider($$interimElementProvider, keyboardLayouts, keyboardD
12611258
console.warn(msg);
12621259
}
12631260
}
1261+
// broadcast new layout
1262+
if (SCOPE) {
1263+
SCOPE.$broadcast('$mdKeyboardLayoutChanged', CURRENT_LAYOUT);
1264+
}
12641265
}
12651266

12661267
// add a custom layout
@@ -1300,7 +1301,7 @@ function MdKeyboardProvider($$interimElementProvider, keyboardLayouts, keyboardD
13001301
numpad: NUMPAD
13011302
};
13021303

1303-
function onShow(scope, element, options, controller) {
1304+
function onShow(scope, element, options) {
13041305

13051306
//if (options.clickOutsideToClose) {
13061307
// document.body.on('click', function () {
@@ -1612,11 +1613,11 @@ function useKeyboardDirective($mdKeyboard, $timeout, $animate, $rootScope) {
16121613
$mdKeyboard.hide('ok');
16131614
};
16141615
$scope.getKeyClass = getKeyClass;
1615-
$scope.keyboard = $mdKeyboard.getCurrentLayout();
1616+
$scope.keyboard = $mdKeyboard.getLayout($mdKeyboard.getCurrentLayout());
16161617
$scope.pressed = triggerKey;
16171618

1618-
$scope.$on('$mdKeyboardLayoutChanged', function () {
1619-
$scope.keyboard = $mdKeyboard.getCurrentLayout();
1619+
$scope.$on('$mdKeyboardLayoutChanged', function ($event, layout) {
1620+
$scope.keyboard = $mdKeyboard.getLayout(layout);
16201621
$scope.$apply();
16211622
});
16221623
};

dist/mdKeyboard.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/mdKeyboard.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,5 @@
5858
"test": "echo \"Error: no test specified\" && exit 1",
5959
"build": "gulp build"
6060
},
61-
"version": "0.0.5"
61+
"version": "0.0.6"
6262
}

src/js/mdKeyboard.directive.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,11 +201,11 @@ function useKeyboardDirective($mdKeyboard, $timeout, $animate, $rootScope) {
201201
$mdKeyboard.hide('ok');
202202
};
203203
$scope.getKeyClass = getKeyClass;
204-
$scope.keyboard = $mdKeyboard.getCurrentLayout();
204+
$scope.keyboard = $mdKeyboard.getLayout($mdKeyboard.getCurrentLayout());
205205
$scope.pressed = triggerKey;
206206

207-
$scope.$on('$mdKeyboardLayoutChanged', function () {
208-
$scope.keyboard = $mdKeyboard.getCurrentLayout();
207+
$scope.$on('$mdKeyboardLayoutChanged', function ($event, layout) {
208+
$scope.keyboard = $mdKeyboard.getLayout(layout);
209209
$scope.$apply();
210210
});
211211
};

src/js/mdKeyboard.provider.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,10 @@ function MdKeyboardProvider($$interimElementProvider, keyboardLayouts, keyboardD
7777

7878
// set name of layout to use
7979
function useLayout(layout) {
80-
if (LAYOUTS[layout]) {
80+
if (layout && LAYOUTS[layout]) {
8181
CURRENT_LAYOUT = layout;
82-
// broadcast new layout
83-
if (SCOPE) {
84-
SCOPE.$broadcast('$mdKeyboardLayoutChanged', CURRENT_LAYOUT);
85-
}
8682
} else {
83+
CURRENT_LAYOUT = DEFAULT_LAYOUT;
8784
if (layout.length) {
8885
var msg = "" +
8986
"The keyboard layout '" + layout + "' does not exists. \n" +
@@ -92,6 +89,10 @@ function MdKeyboardProvider($$interimElementProvider, keyboardLayouts, keyboardD
9289
console.warn(msg);
9390
}
9491
}
92+
// broadcast new layout
93+
if (SCOPE) {
94+
SCOPE.$broadcast('$mdKeyboardLayoutChanged', CURRENT_LAYOUT);
95+
}
9596
}
9697

9798
// add a custom layout
@@ -131,7 +132,7 @@ function MdKeyboardProvider($$interimElementProvider, keyboardLayouts, keyboardD
131132
numpad: NUMPAD
132133
};
133134

134-
function onShow(scope, element, options, controller) {
135+
function onShow(scope, element, options) {
135136

136137
//if (options.clickOutsideToClose) {
137138
// document.body.on('click', function () {

0 commit comments

Comments
 (0)