Replace IList<T> with List<T> where possible (#683)

+semver:patch

Author: hazzik

src/FluentNHibernate/Automapping/AutoJoinedSubClassPart.cs

@@ -11,7 +11,7 @@ public class AutoJoinedSubClassPart<T> : JoinedSubClassPart<T>, IAutoClasslike
 #pragma warning restore 612,618
 {
     readonly MappingProviderStore providers;
-    readonly IList<Member> mappedMembers = new List<Member>();
+    readonly List<Member> mappedMembers = [];
 
     public AutoJoinedSubClassPart(string keyColumn)
         : this(keyColumn, new MappingProviderStore())

src/FluentNHibernate/Automapping/AutoSubClassPart.cs

@@ -11,7 +11,7 @@ public class AutoSubClassPart<T> : SubClassPart<T>, IAutoClasslike
 #pragma warning restore 612,618
 {
     readonly MappingProviderStore providers;
-    readonly IList<Member> mappedMembers = new List<Member>();
+    readonly List<Member> mappedMembers = [];
 
     public AutoSubClassPart(DiscriminatorPart parent, string discriminatorValue)
         : this(parent, discriminatorValue, new MappingProviderStore())

src/FluentNHibernate/Cfg/AutoMappingsContainer.cs

@@ -12,7 +12,7 @@ namespace FluentNHibernate.Cfg;
 /// </summary>
 public class AutoMappingsContainer : IEnumerable<AutoPersistenceModel>
 {
-    readonly IList<AutoPersistenceModel> mappings = new List<AutoPersistenceModel>();
+    readonly List<AutoPersistenceModel> mappings = [];
     string exportPath;
     TextWriter exportTextWriter;
 

src/FluentNHibernate/Cfg/FluentConfiguration.cs

@@ -23,9 +23,9 @@ public class FluentConfiguration
     const string DefaultProxyFactoryFactoryClassName = "NHibernate.ByteCode.Castle.ProxyFactoryFactory, NHibernate.ByteCode.Castle";
     const string CurrentSessionContextClassKey = NHibEnvironment.CurrentSessionContextClass;
 
-    readonly IList<Action<Configuration>> configAlterations = new List<Action<Configuration>>();
+    readonly List<Action<Configuration>> configAlterations = [];
     readonly IDiagnosticMessageDispatcher dispatcher = new DefaultDiagnosticMessageDispatcher();
-    readonly List<Action<MappingConfiguration>> mappingsBuilders = new List<Action<MappingConfiguration>>();
+    readonly List<Action<MappingConfiguration>> mappingsBuilders = [];
 
     bool dbSet;
     bool mappingsSet;

src/FluentNHibernate/Cfg/FluentMappingsContainer.cs

@@ -12,8 +12,8 @@ namespace FluentNHibernate.Cfg;
 /// </summary>
 public class FluentMappingsContainer
 {
-    readonly IList<Assembly> assemblies = new List<Assembly>();
-    readonly List<Type> types = new List<Type>();
+    readonly List<Assembly> assemblies = [];
+    readonly List<Type> types = [];
     readonly IConventionFinder conventionFinder = new DefaultConventionFinder();
     string exportPath;
     TextWriter exportTextWriter;

src/FluentNHibernate/Cfg/HbmMappingsContainer.cs

@@ -10,8 +10,8 @@ namespace FluentNHibernate.Cfg;
 /// </summary>
 public class HbmMappingsContainer
 {
-    readonly IList<Type> classes = new List<Type>();
-    readonly IList<Assembly> assemblies = new List<Assembly>();
+    readonly List<Type> classes = [];
+    readonly List<Assembly> assemblies = [];
 
     internal HbmMappingsContainer()
     {}

src/FluentNHibernate/Mapping/AnyPart.cs

@@ -18,9 +18,9 @@ public class AnyPart<T> : IAnyMappingProvider
     readonly AttributeStore attributes = new AttributeStore();
     readonly Type entity;
     readonly Member member;
-    readonly IList<string> typeColumns = new List<string>();
-    readonly IList<string> identifierColumns = new List<string>();
-    readonly IList<MetaValueMapping> metaValues = new List<MetaValueMapping>();
+    readonly List<string> typeColumns = [];
+    readonly List<string> identifierColumns = [];
+    readonly List<MetaValueMapping> metaValues = [];
     bool nextBool = true;
     bool idTypeSet;
 

src/FluentNHibernate/Mapping/ClassMap.cs

@@ -31,7 +31,7 @@ public class ClassMap<T> : ClasslikeMapBase<T>, IMappingProvider
     protected readonly AttributeStore attributes;
     readonly MappingProviderStore providers;
 
-    readonly IList<ImportPart> imports = new List<ImportPart>();
+    readonly List<ImportPart> imports = [];
     bool nextBool = true;
 
     public ClassMap()

src/FluentNHibernate/Mapping/ColumnMappingCollection.cs

@@ -7,7 +7,7 @@ namespace FluentNHibernate.Mapping;
 
 public class ColumnMappingCollection<TParent>(TParent parent) : IEnumerable<ColumnMapping>
 {
-    readonly IList<ColumnMapping> columns = new List<ColumnMapping>();
+    readonly List<ColumnMapping> columns = [];
 
     public TParent Add(string name)
     {

src/FluentNHibernate/Mapping/CompositeIdentityPart.cs

@@ -15,7 +15,7 @@ public class CompositeIdentityPart<T> : ICompositeIdMappingProvider
 {
     readonly Action<Member> onMemberMapped;
     readonly AttributeStore attributes = new AttributeStore();
-    readonly IList<ICompositeIdKeyMapping> keys = new List<ICompositeIdKeyMapping>();
+    readonly List<ICompositeIdKeyMapping> keys = [];
     bool nextBool = true;
 
     public CompositeIdentityPart(Action<Member> onMemberMapped)

src/FluentNHibernate/Mapping/IdentityPart.cs

@@ -11,7 +11,7 @@ namespace FluentNHibernate.Mapping;
 public class IdentityPart : IIdentityMappingProvider
 {
     readonly AttributeStore columnAttributes = new AttributeStore();
-    readonly IList<string> columns = new List<string>();
+    readonly List<string> columns = [];
     Member member;
     readonly Type entityType;
     readonly AttributeStore attributes = new AttributeStore();

src/FluentNHibernate/Mapping/IndexManyToManyPart.cs

@@ -8,7 +8,7 @@ namespace FluentNHibernate.Mapping;
 
 public class IndexManyToManyPart(Type entity)
 {
-    readonly IList<string> columns = new List<string>();
+    readonly List<string> columns = [];
     readonly AttributeStore attributes = new AttributeStore();
 
     public IndexManyToManyPart Column(string indexColumnName)

src/FluentNHibernate/Mapping/JoinPart.cs

@@ -13,7 +13,7 @@ namespace FluentNHibernate.Mapping;
 public class JoinPart<T> : ClasslikeMapBase<T>, IJoinMappingProvider
 {
     readonly MappingProviderStore providers;
-    readonly IList<string> columns = new List<string>();
+    readonly List<string> columns = [];
     readonly AttributeStore attributes = new AttributeStore();
     bool nextBool = true;
 

src/FluentNHibernate/Mapping/ManyToManyPart.cs

@@ -11,7 +11,7 @@ namespace FluentNHibernate.Mapping;
 
 public class ManyToManyPart<TChild> : ToManyBase<ManyToManyPart<TChild>, TChild>
 {
-    readonly IList<IFilterMappingProvider> childFilters = new List<IFilterMappingProvider>();
+    readonly List<IFilterMappingProvider> childFilters = [];
     IndexManyToManyPart manyToManyIndex;
     IndexPart index;
     readonly Type childType;

src/FluentNHibernate/Mapping/ManyToOnePart.cs

@@ -10,7 +10,7 @@ namespace FluentNHibernate.Mapping;
 
 public class ManyToOnePart<TOther> : IManyToOneMappingProvider
 {
-    readonly IList<string> columns = new List<string>();
+    readonly List<string> columns = [];
     bool nextBool = true;
     readonly AttributeStore attributes = new AttributeStore();
     readonly AttributeStore columnAttributes = new AttributeStore();

src/FluentNHibernate/Mapping/SubclassMap.cs

@@ -31,7 +31,7 @@ public class SubclassMap<T> : ClasslikeMapBase<T>, IIndeterminateSubclassMapping
     // what the parent subclass type is...
     readonly IDictionary<Type, IIndeterminateSubclassMappingProvider> indetermineateSubclasses = new Dictionary<Type, IIndeterminateSubclassMappingProvider>();
     bool nextBool = true;
-    readonly IList<JoinMapping> joins = new List<JoinMapping>();
+    readonly List<JoinMapping> joins = [];
 
     public SubclassMap()
         : this(new MappingProviderStore())

src/FluentNHibernate/Mapping/ToManyBase.cs

@@ -23,6 +23,7 @@ public abstract class ToManyBase<T, TChild> : ICollectionMappingProvider
     Func<AttributeStore, CollectionMapping> collectionBuilder;
     IndexMapping indexMapping;
     protected Member member;
+    readonly List<IFilterMappingProvider> filters = [];
 
     protected ToManyBase(Type entity, Member member, Type type)
     {
@@ -660,7 +661,7 @@ public T ApplyFilter(string name)
         return ApplyFilter<TFilter>(null);
     }
 
-    protected IList<IFilterMappingProvider> Filters { get; } = new List<IFilterMappingProvider>();
+    protected IList<IFilterMappingProvider> Filters => filters;
 
     void SetDefaultCollectionType()
     {

src/FluentNHibernate/MappingModel/AnyMapping.cs

@@ -13,7 +13,7 @@ public class AnyMapping(AttributeStore attributes) : MappingBase, IEquatable<Any
     readonly AttributeStore attributes = attributes;
     readonly LayeredColumns typeColumns = new LayeredColumns();
     readonly LayeredColumns identifierColumns = new LayeredColumns();
-    readonly IList<MetaValueMapping> metaValues = new List<MetaValueMapping>();
+    readonly List<MetaValueMapping> metaValues = [];
 
     public AnyMapping()
         : this(new AttributeStore())

src/FluentNHibernate/MappingModel/ClassBased/ClassMappingBase.cs

@@ -9,7 +9,7 @@ public abstract class ClassMappingBase(AttributeStore attributes) : MappingBase,
 {
     readonly AttributeStore attributes = attributes;
     readonly MappedMembers mappedMembers = new();
-    readonly IList<SubclassMapping> subclasses = new List<SubclassMapping>();
+    readonly List<SubclassMapping> subclasses = [];
 
     public abstract string Name { get; }
     public abstract Type Type { get; }

src/FluentNHibernate/MappingModel/Collections/CollectionMapping.cs

@@ -10,7 +10,7 @@ namespace FluentNHibernate.MappingModel.Collections;
 public class CollectionMapping : MappingBase, IRelationship, IEquatable<CollectionMapping>
 {
     readonly AttributeStore attributes;
-    readonly IList<FilterMapping> filters = new List<FilterMapping>();
+    readonly List<FilterMapping> filters = [];
 
     public Type ContainingEntityType { get; set; }
     public Member Member { get; set; }

src/FluentNHibernate/MappingModel/Collections/ManyToManyMapping.cs

@@ -12,8 +12,9 @@ public class ManyToManyMapping(AttributeStore attributes)
 {
     readonly AttributeStore attributes = attributes;
     readonly LayeredColumns columns = new LayeredColumns();
+    readonly List<FilterMapping> childFilters = [];
 
-    public IList<FilterMapping> ChildFilters { get; } = new List<FilterMapping>();
+    public IList<FilterMapping> ChildFilters => childFilters;
 
     public ManyToManyMapping()
         : this(new AttributeStore())

src/FluentNHibernate/MappingModel/HibernateMapping.cs

@@ -10,9 +10,9 @@ namespace FluentNHibernate.MappingModel;
 [Serializable]
 public class HibernateMapping(AttributeStore attributes) : MappingBase, IEquatable<HibernateMapping>
 {
-    readonly IList<ClassMapping> classes = new List<ClassMapping>();
-    readonly IList<FilterDefinitionMapping> filters = new List<FilterDefinitionMapping>();
-    readonly IList<ImportMapping> imports = new List<ImportMapping>();
+    readonly List<ClassMapping> classes = [];
+    readonly List<FilterDefinitionMapping> filters = [];
+    readonly List<ImportMapping> imports = [];
     readonly AttributeStore attributes = attributes;
 
     public HibernateMapping(): this(new AttributeStore())

src/FluentNHibernate/MappingModel/Identity/CompositeIdMapping.cs

@@ -10,7 +10,7 @@ namespace FluentNHibernate.MappingModel.Identity;
 public class CompositeIdMapping(AttributeStore attributes) : MappingBase, IIdentityMapping, IEquatable<CompositeIdMapping>
 {
     readonly AttributeStore attributes = attributes;
-    readonly IList<ICompositeIdKeyMapping> keys = new List<ICompositeIdKeyMapping>();
+    readonly List<ICompositeIdKeyMapping> keys = [];
 
     public CompositeIdMapping()
         : this(new AttributeStore())

src/FluentNHibernate/MappingModel/Identity/KeyManyToOneMapping.cs

@@ -10,7 +10,7 @@ namespace FluentNHibernate.MappingModel.Identity;
 public class KeyManyToOneMapping : MappingBase, ICompositeIdKeyMapping, IEquatable<KeyManyToOneMapping>
 {
     readonly AttributeStore attributes = new AttributeStore();
-    readonly IList<ColumnMapping> columns = new List<ColumnMapping>();
+    readonly List<ColumnMapping> columns = [];
 
     public override void AcceptVisitor(IMappingModelVisitor visitor)
     {

src/FluentNHibernate/MappingModel/Identity/KeyPropertyMapping.cs

@@ -10,7 +10,7 @@ namespace FluentNHibernate.MappingModel.Identity;
 public class KeyPropertyMapping : MappingBase, ICompositeIdKeyMapping, IEquatable<KeyPropertyMapping>
 {
     readonly AttributeStore attributes = new AttributeStore();
-    readonly IList<ColumnMapping> columns = new List<ColumnMapping>();
+    readonly List<ColumnMapping> columns = [];
 
     public override void AcceptVisitor(IMappingModelVisitor visitor)
     {

src/FluentNHibernate/MappingModel/NaturalIdMapping.cs

@@ -8,8 +8,8 @@ namespace FluentNHibernate.MappingModel;
 public class NaturalIdMapping(AttributeStore attributes) : MappingBase
 {
     readonly AttributeStore attributes = attributes;
-    readonly IList<PropertyMapping> properties = new List<PropertyMapping>();
-    readonly IList<ManyToOneMapping> manyToOnes = new List<ManyToOneMapping>();
+    readonly List<PropertyMapping> properties = [];
+    readonly List<ManyToOneMapping> manyToOnes = [];
 
     public NaturalIdMapping()
         : this(new AttributeStore()) { }