Makes the session available to ISQLExceptionConverter. #217
Conversation
Enables more advanced exception translations based on the persistence context.
| @@ -35,7 +37,7 @@ public void BadGrammar() | |||
| catch (Exception sqle) | |||
| { | |||
| Assert.DoesNotThrow( | |||
| () => ADOExceptionHelper.Convert(sessions.SQLExceptionConverter, sqle, "could not get or update next value", null)); | |||
| () => ADOExceptionHelper.Convert((ISessionImplementor)session, sessions.SQLExceptionConverter, sqle, "could not get or update next value", null)); | |||
There was a problem hiding this comment.
This should be session.GetSessionImplementor()
|
Probably to 5.0.0 as it has a lot of public api changes |
|
I do not see any change in this PR for improving exception messages. The session is available to the sql exception converters, but none of them does anything of it. Correct me if I am wrong. Then it is a lot of changes for no added feature, or only for enabling custom converter implementation to have the session. And it looks like you were intending to infer the entities from the violated constraint name and some inspection of dirty entities in session I guess: it can only work if constraints are named according to entity names (or to table names at least). |
|
Indeed. This PR is rather obsolete now and should probably be discarded. I've since learned that it was really the wrong approach anyway: these days we just try, rollback, infer failure reason from database state, maybe retry. |
|
Ok, thanks for your answer, closing. |
Enables more advanced exception translations based on the persistence
context.
When using batching, details about the entity name and ID which caused a failure are unavailable to the exception converter. Given the name of a violated constraint, however, it is often possible to determine the offending entity by type if we have access to the persistence context. This commit makes the relevant information available to exception converters.