Fetch requests do not work with collection projections

[LodewijkSioen]

Added tests to show #1298 is fixed on the current master.

[bahusoid]

Async code is missing. It can be generated via ShowBuildMenu.bat option H. Please note after
any modifications it needs to be regenerated again. And see my comments below

[LodewijkSioen]

I've run the 'H' option in the buildmenu, but no code was generated...

[bahusoid]

I've run the 'H' option in the buildmenu, but no code was generated...

Well did it give you any error messages? There is async version of this file:
https://github.com/nhibernate/nhibernate-core/blob/master/src/NHibernate.Test/Async/Linq/ProjectionsTests.cs

And for new added tests async counterparts should be generated.

[LodewijkSioen]

Ah, I did have an error, but it wasn't obvious:

     [exec] Starting 'dotnet (../Tools/CSharpAsyncGenerator.CommandLine/0.18.1/tools/netcoreapp2.1/AsyncGenerator.CommandLine.dll)' in 'C:\Projects\External\NHibernate\nhibernate-core\src'
     [exec] Could not execute because the specified command or file was not found.
     [exec] Possible reasons for this include:
     [exec]   * You misspelled a built-in dotnet command.
     [exec]   * You intended to execute a .NET Core program, but dotnet-../Tools/CSharpAsyncGenerator.CommandLine/0.18.1/tools/netcoreapp2.1/AsyncGenerator.CommandLine.dll does not exist.
     [exec]   * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.

I don't have a netcoreapp2.1-folder. Only net472...

[bahusoid]

I don't have a netcoreapp2.1

Well yeah - .net core 2.1 is required to be installed on PC to make async generator work

[LodewijkSioen]

No, I don't have this folder: "../Tools/CSharpAsyncGenerator.CommandLine/0.18.1/tools/netcoreapp2.1/" in my git checkout. only "../Tools/CSharpAsyncGenerator.CommandLine/0.18.1/tools/net472/".

Edit: I deleted my Tools folder, and now the package is restored correctly. I'm going to try and get this fixed tomorrow. Sorry for the inconvenience.

[maca88]

The sql created from this query returns more than 7000 rows, I think that it would be better to use the PatientRecords collection of Patient which has less data:

var query = from o in db.Patients.Fetch(o => o.PatientRecords)
						select new { PatientRecords = o.PatientRecords.ToList() };

the same applies for other queries that were added by this PR.

[LodewijkSioen]

Perhaps I should just add the test from the original bug report. Since doing a Fetch when projecting a collection is actually redundant. Adding that one test will guard against a regression for this code.

[bahusoid]

Perhaps I should just add the test from the original bug report

Fine by me

[maca88]

I am also ok with that.

[LodewijkSioen]

I'm sorry, but I'm unable to build the project using ShowBuildMenu. I emptied my .nuget folder, did a git-clean but I still get this exception: buildlog.txt

Buildding in Visual Studio works, but generating the async code after building in Studio gives me the following exception: asynclog.txt

[hazzik]

The workaround would be to run following in the root of the repository:

dotnet new globaljson --sdk-version 2.1.700 --force

(Please check what 2.1 SDK version you have first)

@maca88 can you investigate support for .net 3.1?

[hazzik]

Which PR has fixed the issue, anyone?

[LodewijkSioen]

I had tried adding a global.json, but I probably used the wrong sdk-version. Anyhow: I changed the test as discussed. Only the test from the original Issue (#1298) is added and the async version is committed.

.