NH-3958: documents missing types, fix broken links #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! But I see you've also added a Sandcastle project file. Please remove that. |
hazzik
reviewed
Mar 5, 2017
| @@ -165,7 +165,7 @@ public class Base { | |||
| <para>Instead of using a string for <methodname>DiscriminatorValue</methodname> (in <classname>[Class]</classname> and <classname>[Subclass]</classname>), you can use any object you want. Example: <programlisting>[Subclass(DiscriminatorValueEnumFormat="d", DiscriminatorValueObject=DiscEnum.Val1)]</programlisting> Here, the object is an Enum, and you can set the format you want (the default value is "g"). Note that you must put it <emphasis role="strong">before</emphasis>! For others types, It simply use the <methodname>ToString()</methodname> method of the object.</para> | |||
| </listitem> | |||
| <listitem> | |||
| <para>If you are using members of the type <classname>Nullables.NullableXXX</classname> (from the library <link linkend="nullables">Nullables</link>), then they will be mapped to <classname>Nullables.NHibernate.NullableXXXType</classname> automatically; don't set <literal>Type="..."</literal> in <classname>[Property]</classname> (leave it null). This is also the case for <classname>SqlTypes</classname> (and you can add your own patterns). Thanks to <emphasis>Michael Third</emphasis> for the idea :)</para> | |||
| <para>If you are using members of the type <classname>Nullables.NullableXXX</classname> (from the library Nullables), then they will be mapped to <classname>Nullables.NHibernate.NullableXXXType</classname> automatically; don't set <literal>Type="..."</literal> in <classname>[Property]</classname> (leave it null). This is also the case for <classname>SqlTypes</classname> (and you can add your own patterns). Thanks to <emphasis>Michael Third</emphasis> for the idea :)</para> | |||
There was a problem hiding this comment.
I think this has to be removed completely. As this, probably does not happen currently. And, nobody is using Nullables library.
…k to a probably obsolete library.
fredericDelaporte
force-pushed
the
NH-3958
branch
from
f096f65 to
bc19bc5
Compare
|
Sorry for the sandcastle project, I have removed it. I wanted to gitignore it, but done that in another branch. Now I have put a .gitignore in this branch. The Nant build generates this sandcastle project, so it seems legit to ignore it in doc folder. |
hazzik
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NH-3958: adding some missing NHibernate types in reference documentation.
Fix two broken links, one updated, the other one removed (referencing old Nullables library).
Pushed api version in documentation from 4.0 to 5.0.