Add tests for PDS lookup history

Adds tests for PDS lookup history methods and the new timeline component.

Author: murugapl

app/models/pds_search_result.rb

@@ -88,7 +88,7 @@ def timeline_item
       description:
         I18n.t(
           "activerecord.attributes.#{self.class.model_name.i18n_key}.results.#{result}",
-          nhs_number: pds_nhs_number || nhs_number
+          nhs_number: nhs_number
         )
     }
   end

spec/components/app_child_summary_component_spec.rb

@@ -124,4 +124,44 @@
     it { should have_text("Archive reason") }
     it { should have_text("Other: Some details.") }
   end
+
+  context "with a PDS lookup match" do
+    let(:patient) { create(:patient) }
+
+    before { allow(patient).to receive(:pds_lookup_match?).and_return(true) }
+
+    it "shows a PDS history action link" do
+      render_inline(described_class.new(patient))
+
+      expect(page).to have_link(
+        "PDS history",
+        href:
+          Rails.application.routes.url_helpers.pds_search_history_patient_path(
+            patient
+          )
+      )
+    end
+  end
+
+  context "without a PDS lookup match" do
+    let(:patient) { create(:patient) }
+
+    before { allow(patient).to receive(:pds_lookup_match?).and_return(false) }
+
+    it "does not show a PDS history link" do
+      render_inline(described_class.new(patient))
+
+      expect(page).not_to have_link("PDS history")
+    end
+
+    context "when the record is not a Patient" do
+      let(:consent_form) { create(:consent_form) }
+
+      it "does not show a PDS history link" do
+        render_inline(described_class.new(consent_form))
+
+        expect(page).not_to have_link("PDS history")
+      end
+    end
+  end
 end

spec/components/app_timeline_component_spec.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+describe AppTimelineComponent, type: :component do
+  subject(:rendered) { render_inline(described_class.new(items: items)) }
+
+  context "when there are no items" do
+    let(:items) { [] }
+
+    it "does not render" do
+      expect(rendered.to_html).to be_blank
+    end
+  end
+
+  context "when items are present" do
+    let(:items) do
+      [
+        { heading_text: "Step 1", description: "First step", active: true },
+        {
+          heading_text: "Step 2",
+          description: "Past step",
+          is_past_item: true
+        },
+        { heading_text: "Step 3", description: "Future step" }
+      ]
+    end
+
+    it "renders a list of timeline items" do
+      expect(rendered.css("ul.app-timeline li.app-timeline__item").count).to eq(
+        3
+      )
+    end
+
+    it "renders the heading text" do
+      expect(rendered).to have_text("Step 1")
+      expect(rendered).to have_text("Step 2")
+      expect(rendered).to have_text("Step 3")
+    end
+
+    it "renders the description text" do
+      expect(rendered).to have_text("First step")
+      expect(rendered).to have_text("Past step")
+      expect(rendered).to have_text("Future step")
+    end
+
+    it "renders a bold header for active items" do
+      expect(rendered.css("h3.nhsuk-u-font-weight-bold")).to have_text("Step 1")
+    end
+
+    it "renders a large badge for active and past items" do
+      expect(rendered.css("svg.app-timeline__badge")).to be_present
+    end
+
+    it "renders a small badge for future items" do
+      expect(rendered.css("svg.app-timeline__badge--small")).to be_present
+    end
+  end
+
+  context "when an item is blank" do
+    let(:items) { [nil, { heading_text: "Step X", description: "Valid" }] }
+
+    it "skips rendering blank items" do
+      expect(rendered.css("li.app-timeline__item").count).to eq(1)
+      expect(rendered).to have_text("Step X")
+    end
+  end
+end

spec/features/import_child_pds_lookup_extravaganza_spec.rb

@@ -19,9 +19,12 @@
     # Case 1: Patient with existing NHS number (Albert) - nothing should happen
     and_i_see_the_patient_uploaded_with_nhs_number
     and_parents_are_created_for_albert
+    when_i_click_on_alberts_pds_history
+    then_i_see_the_pds_lookup_history
 
     # Case 2: Existing patient without NHS number (Betty) - should not show duplicate review
-    and_i_do_not_see_an_import_review_for_the_first_patient_uploaded_without_nhs_number
+    when_i_go_back_to_the_import_page
+    then_i_do_not_see_an_import_review_for_the_first_patient_uploaded_without_nhs_number
     when_i_click_on_the_patient_without_review
     then_i_see_the_new_patient_has_an_nhs_number
     and_betty_has_correct_parent_relationships
@@ -272,12 +275,14 @@ def and_an_existing_patient_record_exists
   def and_pds_lookup_during_import_is_enabled
     Flipper.enable(:pds_lookup_during_import)
 
-    stub_pds_search_to_return_a_patient(
-      "9999075320",
-      "family" => "Tweedle",
-      "given" => "Albert",
-      "birthdate" => "eq2009-12-29",
-      "address-postalcode" => "SW11 1EH"
+    stub_pds_cascading_search(
+      family_name: "Tweedle",
+      given_name: "Albert",
+      birthdate: "eq2009-12-29",
+      address_postcode: "SW11 1EH",
+      steps: {
+        wildcard_family_name: "9999075320"
+      }
     )
 
     stub_pds_search_to_return_a_patient(
@@ -416,6 +421,11 @@ def when_i_click_review_for(name)
     end
   end
 
+  def when_i_click_on_alberts_pds_history
+    click_on "TWEEDLE, Albert"
+    click_link "PDS history"
+  end
+
   def and_i_upload_import_file(filename)
     click_button "Import records"
     choose "Child records"
@@ -447,6 +457,10 @@ def then_i_should_see_the_import_page
     expect(page).to have_content("Import class list")
   end
 
+  def then_i_see_the_pds_lookup_history
+    expect(page).to have_content("NHS number lookup history")
+  end
+
   def when_i_upload_a_valid_file
     attach_file(
       "class_import[csv]",
@@ -526,7 +540,7 @@ def and_an_existing_patient_records_exist_in_school
       )
   end
 
-  def and_i_do_not_see_an_import_review_for_the_first_patient_uploaded_without_nhs_number
+  def then_i_do_not_see_an_import_review_for_the_first_patient_uploaded_without_nhs_number
     expect(page).not_to have_content("Actions Review SAMSON, Betty")
   end
 

spec/models/patient_spec.rb

@@ -1082,4 +1082,86 @@
       end
     end
   end
+
+  describe "#latest_pds_search_result" do
+    subject(:latest_pds_search_result) { patient.latest_pds_search_result }
+
+    let(:patient) { create(:patient) }
+
+    context "with no PDS search results" do
+      it { should be_nil }
+    end
+
+    context "with PDS search results but no changeset" do
+      let(:import) { create(:class_import) }
+
+      before { create(:pds_search_result, patient:, import:) }
+
+      it { should be_nil }
+    end
+
+    context "with PDS search results and changeset" do
+      let(:import) { create(:class_import) }
+
+      before do
+        create(
+          :patient_changeset,
+          patient:,
+          import:,
+          pds_nhs_number: "9449304130"
+        )
+        create(:pds_search_result, patient:, import:)
+      end
+
+      it { should eq("9449304130") }
+    end
+  end
+
+  describe "#pds_lookup_match?" do
+    subject(:pds_lookup_match?) { patient.pds_lookup_match? }
+
+    let(:patient) { create(:patient, nhs_number: "9449304130") }
+
+    context "when patient has no NHS number" do
+      let(:patient) { create(:patient, nhs_number: nil) }
+
+      it { should be(false) }
+    end
+
+    context "with no PDS search results" do
+      it { should be(false) }
+    end
+
+    context "with matching PDS search result" do
+      let(:import) { create(:class_import) }
+
+      before do
+        create(
+          :patient_changeset,
+          patient:,
+          import:,
+          pds_nhs_number: "9449304130"
+        )
+        create(:pds_search_result, patient:, import:)
+      end
+
+      it { should be(true) }
+    end
+
+    context "with non-matching PDS search result" do
+      let(:import) { create(:class_import) }
+
+      before do
+        create(
+          :patient_changeset,
+          patient:,
+          import:,
+          pds_nhs_number: "9449310475"
+        )
+        create(:pds_search_result, patient:, import:)
+      end
+
+      it { should be(false) }
+    end
+  end
 end