Merge pull request #4543 from nhsuk/programme-tag-order

Ensure programme tags are ordered

Author: thomasleese

app/components/app_programme_tags_component.rb

@@ -5,16 +5,13 @@ def initialize(programmes)
     @programmes = programmes
   end
 
-  def call
-    safe_join(
-      programmes.map do
-        tag.strong(it.name, class: "nhsuk-tag nhsuk-tag--white")
-      end,
-      " "
-    )
-  end
+  def call = safe_join(tags, " ")
 
   private
 
   attr_reader :programmes
+
+  def names = programmes.map(&:name).sort
+
+  def tags = names.map { tag.strong(it, class: "nhsuk-tag nhsuk-tag--white") }
 end

spec/components/app_programme_tags_component_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+describe AppProgrammeTagsComponent do
+  subject { render_inline(component) }
+
+  let(:component) { described_class.new(programmes) }
+
+  let(:programmes) do
+    [create(:programme, :menacwy), create(:programme, :td_ipv)]
+  end
+
+  it { should have_content("MenACWY Td/IPV") }
+
+  context "with unordered programmes" do
+    let(:programmes) do
+      [create(:programme, :td_ipv), create(:programme, :menacwy)]
+    end
+
+    it { should have_content("MenACWY Td/IPV") }
+  end
+end