Remove contact injection wizard step

thomasleese · thomasleese · commit 373360ff07eb · 2025-06-06T08:18:48.000+01:00
The design has changed quite a bit since this was first built and we're
going to start refactoring the data model in preparation for the new
design. Rather than needing to keep this old design working (which is
not being used at all) with the new data model, I think it'll probably
be easier to remove this code and then bring it back under the new
designs later.
diff --git a/app/components/app_consent_confirmation_component.rb b/app/components/app_consent_confirmation_component.rb
@@ -4,10 +4,6 @@ class AppConsentConfirmationComponent < ViewComponent::Base
   erb_template <<-ERB
     <%= govuk_panel(title_text: title, text: panel_text) %>
 
-    <% if @consent_form.contact_injection %>
-      <p>Someone will be in touch to discuss them having an injection instead.</p>
-    <% end %>
-
     <p>We've sent a confirmation to <%= parent_email %></p>
   ERB
 
@@ -18,20 +14,16 @@ def initialize(consent_form)
   end
 
   def title
-    if @consent_form.contact_injection
-      "Your child will not get a nasal flu vaccination at school"
+    case response
+    when "given"
+      "Consent confirmed"
+    when "given_one"
+      chosen_programme = chosen_programmes.first.name
+      "Consent for the #{chosen_programme} vaccination confirmed"
+    when "refused"
+      "Consent refused"
     else
-      case response
-      when "given"
-        "Consent confirmed"
-      when "given_one"
-        chosen_programme = chosen_programmes.first.name
-        "Consent for the #{chosen_programme} vaccination confirmed"
-      when "refused"
-        "Consent refused"
-      else
-        raise "unrecognised consent response: #{response}"
-      end
+      raise "unrecognised consent response: #{response}"
     end
   end
 
diff --git a/app/controllers/concerns/consent_form_mailer_concern.rb b/app/controllers/concerns/consent_form_mailer_concern.rb
@@ -4,12 +4,7 @@ module ConsentFormMailerConcern
   extend ActiveSupport::Concern
 
   def send_consent_form_confirmation(consent_form)
-    if consent_form.contact_injection?
-      EmailDeliveryJob.perform_later(
-        :consent_confirmation_injection,
-        consent_form:
-      )
-    elsif consent_form.consent_refused?
+    if consent_form.consent_refused?
       send_consent_form_confirmation_refused(consent_form)
     else
       ProgrammeGrouper
diff --git a/app/controllers/parent_interface/consent_forms/edit_controller.rb b/app/controllers/parent_interface/consent_forms/edit_controller.rb
@@ -97,7 +97,6 @@ def update_params
         consent: %i[response chosen_vaccine],
         reason: %i[reason],
         reason_notes: %i[reason_notes],
-        injection: %i[contact_injection],
         address: %i[address_line_1 address_line_2 address_town address_postcode]
       }.fetch(current_step)
 
diff --git a/app/models/consent_form.rb b/app/models/consent_form.rb
@@ -11,7 +11,6 @@
 #  address_town                        :string
 #  archived_at                         :datetime
 #  chosen_vaccine                      :string
-#  contact_injection                   :boolean
 #  date_of_birth                       :date
 #  education_setting                   :integer
 #  family_name                         :text
@@ -245,10 +244,6 @@ class ConsentForm < ApplicationRecord
     validates :reason_notes, presence: true
   end
 
-  on_wizard_step :injection do
-    validates :contact_injection, inclusion: { in: [true, false] }
-  end
-
   on_wizard_step :address do
     validates :address_line_1, presence: true
     validates :address_town, presence: true
@@ -271,7 +266,6 @@ def wizard_steps
       :consent,
       (:reason if consent_refused?),
       (:reason_notes if consent_refused? && reason_notes_must_be_provided?),
-      (:injection if injection_offered_as_alternative?),
       (:address if consent_given? || consent_given_one?),
       (:health_question if consent_given? || consent_given_one?),
       (:reason if consent_given_one?),
@@ -499,24 +493,6 @@ def academic_year
     created_at.to_date.academic_year
   end
 
-  def refused_and_not_had_it_already?
-    consent_refused? && !refused_because_will_be_vaccinated_elsewhere? &&
-      !refused_because_already_vaccinated?
-  end
-
-  def injection_offered_as_alternative?
-    refused_and_not_had_it_already? && programmes.any?(&:flu?)
-    # checking for flu here is a simplification
-    # the actual logic is: if the parent has refused a nasal vaccine AND the session is for a nasal vaccine
-    # AND the SAIS organisation offers an alternative injection vaccine, then show the injection step
-    #
-    # we currently don't track what type of vaccine was refused.
-    # currently HPV is only offered as an injection, so we don't need to check for it
-    #
-    # so a more true-to-life implementation would be:
-    # refused_nasal? && not_had_it_already? && injection_offered_as_alternative?
-  end
-
   def health_answers_valid?
     if health_question_number.present?
       unless health_answers[health_question_number].valid?
@@ -577,8 +553,6 @@ def reset_unused_fields
       self.reason_notes = nil
     end
 
-    self.contact_injection = nil if consent_given? || consent_given_one?
-
     if school_confirmed
       self.education_setting = "school"
       self.school = location
diff --git a/app/views/parent_interface/consent_forms/confirm.html.erb b/app/views/parent_interface/consent_forms/confirm.html.erb
@@ -115,20 +115,6 @@
                               href: change_link[:reason],
                               visually_hidden_text: "reason for refusal")
             end
-        
-            if !@consent_form.contact_injection.nil?
-              summary_list.with_row do |row|
-                row.with_key { "Alternative option" }
-                row.with_value {
-                  @consent_form.contact_injection? ?
-                    "Someone can contact me about an injection" :
-                    "No"
-                }
-                row.with_action(text: "Change",
-                                href: change_link[:injection],
-                                visually_hidden_text: "alternative option")
-              end
-            end
           end
         end %>
   <% end %>
diff --git a/app/views/parent_interface/consent_forms/edit/injection.html.erb b/app/views/parent_interface/consent_forms/edit/injection.html.erb
diff --git a/config/initializers/govuk_notify.rb b/config/initializers/govuk_notify.rb
@@ -4,7 +4,6 @@
   consent_clinic_request: "14e88a09-4281-4257-9574-6afeaeb42715",
   consent_confirmation_clinic: "f2921e23-4b73-4e44-abbb-38b0e235db8e",
   consent_confirmation_given: "7cda7ae5-99a2-4c40-9a3e-1863e23f7a73",
-  consent_confirmation_injection: "4d09483a-8181-4acb-8ba3-7abd6c8644cd",
   consent_confirmation_refused: "5a676dac-3385-49e4-98c2-fc6b45b5a851",
   consent_confirmation_triage: "604ee667-c996-471e-b986-79ab98d0767c",
   consent_school_initial_reminder_doubles:
diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -256,8 +256,6 @@ en:
             address_town:
               blank: Enter a town or city
               too_long: Enter a town or city that is less than 300 characters long
-            contact_injection:
-              inclusion: Choose if you want to be contacted
             date_of_birth:
               blank: Enter their date of birth
               greater_than_or_equal_to: The child cannot be older than 22. Enter a date after %{count}.
@@ -694,7 +692,6 @@ en:
     file_format: file-format
     gp: gp
     health_question: health-question
-    injection: injection
     location: location
     name: name
     notes: notes
diff --git a/db/migrate/20250606070424_remove_contact_injection_from_consent_forms.rb b/db/migrate/20250606070424_remove_contact_injection_from_consent_forms.rb
@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class RemoveContactInjectionFromConsentForms < ActiveRecord::Migration[8.0]
+  def change
+    remove_column :consent_forms, :contact_injection, :boolean
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[8.0].define(version: 2025_05_22_140257) do
+ActiveRecord::Schema[8.0].define(version: 2025_06_06_070424) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_catalog.plpgsql"
   enable_extension "pg_trgm"
@@ -170,7 +170,6 @@
     t.integer "response"
     t.integer "reason"
     t.text "reason_notes"
-    t.boolean "contact_injection"
     t.string "address_line_1"
     t.string "address_line_2"
     t.string "address_town"
diff --git a/spec/controllers/concerns/consent_form_mailer_concern_spec.rb b/spec/controllers/concerns/consent_form_mailer_concern_spec.rb
@@ -22,20 +22,6 @@
       ).with(consent_form:, programmes: consent_form.programmes)
     end
 
-    context "when user agrees to be contacted about injections" do
-      before { consent_form.contact_injection = true }
-
-      it "sends an injection confirmation email" do
-        expect { send_consent_form_confirmation }.to have_delivered_email(
-          :consent_confirmation_injection
-        ).with(consent_form:)
-      end
-
-      it "doesn't send a text" do
-        expect { send_consent_form_confirmation }.not_to have_delivered_sms
-      end
-    end
-
     context "when user refuses consent" do
       before { consent_form.response = :refused }
 
diff --git a/spec/factories/consent_forms.rb b/spec/factories/consent_forms.rb
@@ -11,7 +11,6 @@
 #  address_town                        :string
 #  archived_at                         :datetime
 #  chosen_vaccine                      :string
-#  contact_injection                   :boolean
 #  date_of_birth                       :date
 #  education_setting                   :integer
 #  family_name                         :text
diff --git a/spec/features/parental_consent_change_answers_spec.rb b/spec/features/parental_consent_change_answers_spec.rb
@@ -43,26 +43,12 @@
     then_i_see_the_needs_triage_confirmation_page
   end
 
-  scenario "Offer an injection instead" do
-    when_i_go_to_a_prefilled_consent_form
-    then_i_see_the_consent_form_confirmation_page
-
-    when_i_change_my_consent_to_refused
-    and_say_the_reason_is_that_the_vaccine_contains_gelatine
-    and_agree_to_be_contacted_by_a_nurse
-    then_i_see_the_consent_form_confirmation_page
-
-    when_i_click_the_confirm_button
-    then_i_see_the_injection_confirmation_page
-  end
-
   scenario "Consent refused" do
     when_i_go_to_a_prefilled_consent_form
     then_i_see_the_consent_form_confirmation_page
 
     when_i_change_my_consent_to_refused
     and_say_the_reason_is_that_the_vaccine_contains_gelatine
-    and_do_not_agree_to_be_contacted_by_a_nurse
     then_i_see_the_consent_form_confirmation_page
 
     when_i_change_my_consent_to_accepted
@@ -242,22 +228,6 @@ def and_say_the_reason_is_that_the_vaccine_contains_gelatine
     click_button "Continue"
   end
 
-  def and_agree_to_be_contacted_by_a_nurse
-    expect(page).to have_content(
-      "Your child may be able to have an injection instead"
-    )
-    choose "Yes, I am happy for someone to contact me"
-    click_button "Continue"
-  end
-
-  def and_do_not_agree_to_be_contacted_by_a_nurse
-    expect(page).to have_content(
-      "Your child may be able to have an injection instead"
-    )
-    choose "No"
-    click_button "Continue"
-  end
-
   def when_i_click_the_confirm_button
     click_button "Confirm"
   end
@@ -282,15 +252,6 @@ def then_i_see_the_given_confirmation_page
     )
   end
 
-  def then_i_see_the_injection_confirmation_page
-    expect(page).to have_content(
-      "Your child will not get a nasal flu vaccination at school"
-    )
-    expect(page).to have_content(
-      "Someone will be in touch to discuss them having an injection instead."
-    )
-  end
-
   def then_i_see_the_address_page
     expect(page).to have_content("Home address")
   end
diff --git a/spec/models/consent_form_spec.rb b/spec/models/consent_form_spec.rb
