Remove draft parents

We no longer need the concept of draft parents as we record consent in
the browser session and only commit to the database after the confirm
step. This helps to clean up the data in our database and avoid draft
records accidentally being exposed or simply existing with no purpose.

Author: thomasleese

app/models/consent.rb

@@ -50,12 +50,7 @@ class Consent < ApplicationRecord
   belongs_to :organisation
 
   has_one :consent_form
-  belongs_to :parent, -> { recorded }, optional: true
-  belongs_to :draft_parent,
-             -> { draft },
-             class_name: "Parent",
-             optional: true,
-             foreign_key: :parent_id
+  belongs_to :parent, optional: true
   belongs_to :recorded_by,
              class_name: "User",
              optional: true,
@@ -133,7 +128,7 @@ def triage_needed?
   end
 
   def parent_relationship
-    (parent || draft_parent)&.relationship_to(patient:)
+    parent&.relationship_to(patient:)
   end
 
   def who_responded
@@ -181,8 +176,6 @@ def notes_required?
   private
 
   def parent_present_unless_self_consent
-    if draft? && !via_self_consent? && draft_parent.nil? && parent.nil?
-      errors.add(:draft_parent, :blank)
-    end
+    errors.add(:parent, :blank) if parent.nil? && !via_self_consent?
   end
 end

app/models/consent_form.rb

@@ -370,8 +370,6 @@ def find_or_create_parent_with_relationship_to!(patient:)
         full_name: parent_full_name
       ) || Parent.new
 
-    parent.recorded_at = Time.current unless parent.recorded?
-
     parent.update!(
       email: parent_email,
       full_name: parent_full_name,

app/models/draft_consent.rb

@@ -159,7 +159,6 @@ def parent
     parent.full_name = parent_full_name
     parent.phone = parent_phone
     parent.phone_receive_updates = parent_phone_receive_updates
-    parent.recorded_at = Time.current
 
     parent
       .parent_relationships

app/models/parent.rb

@@ -11,7 +11,6 @@
 #  full_name                    :string
 #  phone                        :string
 #  phone_receive_updates        :boolean          default(FALSE), not null
-#  recorded_at                  :datetime
 #  created_at                   :datetime         not null
 #  updated_at                   :datetime         not null
 #
@@ -20,8 +19,6 @@
 #  index_parents_on_email  (email)
 #
 class Parent < ApplicationRecord
-  include Recordable
-
   audited
 
   before_save :reset_unused_fields

app/models/patient_import_row.rb

@@ -111,8 +111,6 @@ def to_parents
           full_name:
         ) || Parent.new
 
-      parent.recorded_at = Time.current unless parent.recorded?
-
       parent.email = attributes[:email] if attributes[:email]
       parent.full_name = attributes[:full_name] if attributes[:full_name]
       parent.phone = attributes[:phone] if attributes[:phone]

app/views/draft_consents/parent_details.html.erb

@@ -5,7 +5,7 @@
       ) %>
 <% end %>
 
-<% page_title = if @parent.recorded?
+<% page_title = if @parent.persisted?
        "Details for #{@parent.label_to(patient: @patient)}"
      else
        "Details for parent or guardian"

db/migrate/20241118111318_remove_recorded_at_from_parents.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class RemoveRecordedAtFromParents < ActiveRecord::Migration[7.2]
+  def change
+    reversible do |dir|
+      dir.up do
+        Parent
+          .where(recorded_at: nil)
+          .find_each do |parent|
+            parent.parent_relationships.destroy_all
+            parent.destroy!
+          end
+      end
+    end
+
+    remove_column :parents, :recorded_at, :datetime
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.2].define(version: 2024_11_18_094122) do
+ActiveRecord::Schema[7.2].define(version: 2024_11_18_111318) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_trgm"
   enable_extension "plpgsql"
@@ -519,7 +519,6 @@
     t.text "contact_method_other_details"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
-    t.datetime "recorded_at"
     t.string "contact_method_type"
     t.boolean "phone_receive_updates", default: false, null: false
     t.index ["email"], name: "index_parents_on_email"

erd.pdf

@@ -24,8 +24,8 @@
     create(:patient, school: location, given_name: "Sarah", family_name: "Doe")
   end
 
-  let(:mum) { create(:parent, :recorded, full_name: "Jane Doe") }
-  let(:dad) { create(:parent, :recorded, full_name: "John Doe") }
+  let(:mum) { create(:parent, full_name: "Jane Doe") }
+  let(:dad) { create(:parent, full_name: "John Doe") }
 
   before do
     create(:parent_relationship, :mother, parent: mum, patient:)