Merge pull request #4739 from nhsuk/fix-low-pds-match-rate-rendering

Fix low pds match rate rendering

Author: murugapl

app/assets/stylesheets/vendor/nhsuk-frontend/overrides/_index.scss

@@ -1,2 +1,3 @@
+@forward "details";
 @forward "summary-list";
 @forward "tables";

app/components/app_import_pds_unmatched_summary_component.rb

@@ -2,7 +2,7 @@
 
 class AppImportPDSUnmatchedSummaryComponent < ViewComponent::Base
   def initialize(changesets:)
-    @changesets = changesets
+    @changesets = changesets.sort_by(&:row_number)
   end
 
   def call

app/views/imports/show.html.erb

@@ -101,7 +101,7 @@
   <% end %>
 
   <details class="nhsuk-details nhsuk-expander">
-    <summary class="nhsuk-details__summary" data-module="app-sticky" data-app-sticky-init>
+    <summary class="nhsuk-details__summary" data-module="app-sticky">
       <span class="nhsuk-details__summary-text">
         <%= import.changesets.without_pds_match.count %> unmatched records
       </span>

db/seeds.rb

@@ -203,6 +203,20 @@ def create_imports(user, team)
       uploaded_by: user
     )
   end
+
+  low_pds_import =
+    FactoryBot.create(
+      :cohort_import,
+      :low_pds_match_rate,
+      team:,
+      uploaded_by: user
+    )
+  FactoryBot.create_list(
+    :patient_changeset,
+    15,
+    import: low_pds_import,
+    pds_nhs_number: nil
+  )
 end
 
 def create_school_moves(team)

spec/components/app_import_pds_unmatched_summary_component_spec.rb

@@ -20,7 +20,8 @@
           "address_postcode" => "AB1 2CD"
         }
       },
-      import:
+      import:,
+      row_number: 2
     )
   end
 
@@ -52,7 +53,8 @@
             "address_postcode" => "ZZ9 9ZZ"
           }
         },
-        import:
+        import:,
+        row_number: 1
       )
     end
 
@@ -63,6 +65,13 @@
       expect(rendered).to have_content("20 August 2011")
       expect(rendered).to have_content("ZZ9 9ZZ")
     end
+
+    it "renders records in row number order" do
+      rows = rendered.css("tbody tr").map(&:text)
+
+      expect(rows.first).to include("Bob")
+      expect(rows.last).to include("Alice")
+    end
   end
 
   context "when values are blank" do