Remove session association from AttendanceRecord

This replaces the session association with one to the location instead,
as we want registration status to apply across all sessions for a
particular location, in preparation for the removal of the
`PatientSession` model.

Jira-Issue: MAV-1938

Author: thomasleese

app/components/app_patient_session_search_result_card_component.rb

@@ -98,9 +98,12 @@ def can_register_attendance?
     attendance_record =
       AttendanceRecord.new(
         patient:,
-        session_date: SessionDate.new(session:, value: Date.current)
+        location: session.location,
+        date: Date.current
       )
 
+    attendance_record.session = session
+
     policy(attendance_record).new?
   end
 

app/controllers/patient_sessions/attendances_controller.rb

@@ -42,18 +42,20 @@ def update
   private
 
   def set_attendance_record
-    @attendance_record =
-      authorize(
-        @patient
-          .attendance_records
-          .includes(:patient, session_date: { session: :programmes })
-          .find_or_initialize_by(session_date: @session_date)
+    attendance_record =
+      @patient.attendance_records.find_or_initialize_by(
+        location: @session.location,
+        date: @session_date.value
       )
+
+    attendance_record.session = @session
+
+    @attendance_record = authorize attendance_record
   end
 
   def attendance_record_params
     params
       .expect(attendance_record: :attending)
-      .tap { |p| p[:attending] = nil if p[:attending] == "not_registered" }
+      .tap { it[:attending] = nil if it[:attending] == "not_registered" }
   end
 end

app/controllers/sessions/register_controller.rb

@@ -26,16 +26,19 @@ def show
 
   def create
     attendance_record =
-      ActiveRecord::Base.transaction do
-        record =
-          authorize @patient
-                      .attendance_records
-                      .includes(:session_date)
-                      .find_or_initialize_by(session_date: @session_date)
-        record.update!(attending: params[:status] == "present")
-        StatusUpdater.call(patient: @patient)
-        record
-      end
+      @patient.attendance_records.find_or_initialize_by(
+        location: @session.location,
+        date: @session_date.value
+      )
+
+    attendance_record.session = @session
+
+    authorize attendance_record
+
+    ActiveRecord::Base.transaction do
+      attendance_record.update!(attending: params[:status] == "present")
+      StatusUpdater.call(patient: @patient)
+    end
 
     name = @patient.full_name
 

app/lib/generate/vaccination_records.rb

@@ -26,12 +26,7 @@ def create_vaccinations
       patient = patient_session.patient
       session = patient_session.session
 
-      unless AttendanceRecord.joins(:session_date).exists?(
-               patient:,
-               session_date: {
-                 session:
-               }
-             )
+      unless AttendanceRecord.exists?(patient:, location: session.location)
         attendance_records << FactoryBot.build(
           :attendance_record,
           :present,

app/lib/status_updater.rb

@@ -63,7 +63,6 @@ def update_registration_statuses!
       .includes(
         :patient,
         :attendance_records,
-        :session_date,
         :vaccination_records,
         session: :programmes
       )

app/models/attendance_record.rb

@@ -4,34 +4,35 @@
 #
 # Table name: attendance_records
 #
-#  id              :bigint           not null, primary key
-#  attending       :boolean          not null
-#  created_at      :datetime         not null
-#  updated_at      :datetime         not null
-#  patient_id      :bigint           not null
-#  session_date_id :bigint           not null
+#  id          :bigint           not null, primary key
+#  attending   :boolean          not null
+#  date        :date             not null
+#  created_at  :datetime         not null
+#  updated_at  :datetime         not null
+#  location_id :bigint           not null
+#  patient_id  :bigint           not null
 #
 # Indexes
 #
-#  index_attendance_records_on_patient_id                      (patient_id)
-#  index_attendance_records_on_patient_id_and_session_date_id  (patient_id,session_date_id) UNIQUE
-#  index_attendance_records_on_session_date_id                 (session_date_id)
+#  idx_on_patient_id_location_id_date_e5912f40c4  (patient_id,location_id,date) UNIQUE
+#  index_attendance_records_on_location_id        (location_id)
+#  index_attendance_records_on_patient_id         (patient_id)
 #
 # Foreign Keys
 #
+#  fk_rails_...  (location_id => locations.id)
 #  fk_rails_...  (patient_id => patients.id)
-#  fk_rails_...  (session_date_id => session_dates.id)
 #
 class AttendanceRecord < ApplicationRecord
   audited associated_with: :patient
 
   belongs_to :patient
-  belongs_to :session_date
+  belongs_to :location
 
-  has_one :session, through: :session_date
-  has_one :location, through: :session
+  scope :today, -> { where(date: Date.current) }
 
-  scope :today, -> { joins(:session_date).merge(SessionDate.today) }
+  delegate :today?, to: :date
 
-  delegate :today?, to: :session_date
+  # This is needed to be able to pass a session to the policy.
+  attr_accessor :session
 end

app/models/location.rb

@@ -53,6 +53,7 @@ class Location < ApplicationRecord
              primary_key: :gias_code,
              optional: true
 
+  has_many :attendance_records
   has_many :consent_forms
   has_many :location_programme_year_groups
   has_many :patients, foreign_key: :school_id

app/models/patient/registration_status.rb

@@ -29,8 +29,6 @@ class Patient::RegistrationStatus < ApplicationRecord
            -> { kept.order(performed_at: :desc) },
            through: :patient
 
-  has_one :session_date, -> { today }, through: :session, source: :session_dates
-
   has_many :attendance_records, through: :patient
 
   enum :status,
@@ -39,7 +37,9 @@ class Patient::RegistrationStatus < ApplicationRecord
        validate: true
 
   def attendance_record
-    attendance_records.find { it.session_date_id == session_date&.id }
+    attendance_records.find do
+      it.location_id == session.location_id && it.today?
+    end
   end
 
   def assign_status

app/models/patient_session.rb

@@ -72,7 +72,7 @@ class PatientSession < ApplicationRecord
 
   has_many :attendance_records,
            -> { where(patient_id: it.patient_id) },
-           through: :session
+           through: :location
 
   has_many :session_notifications,
            -> { where(session_id: it.session_id) },

app/models/session.rb

@@ -55,7 +55,6 @@ class Session < ApplicationRecord
   has_many :programmes, through: :session_programmes
   has_many :gillick_assessments, through: :session_dates
   has_many :patients, through: :patient_sessions
-  has_many :attendance_records, through: :session_dates
   has_many :vaccines, through: :programmes
 
   has_many :location_programme_year_groups,