Add CSVImportable#record!

This extracts the `record!` method from `ImmunisationImport` to the
common concern used by it and `CohortImport` to ensure that the
behaviour is the same across both import models.

Author: thomasleese

app/controllers/cohort_lists_controller.rb

@@ -27,6 +27,8 @@ def create
 
     @cohort_import.process!
 
+    @cohort_import.record!
+
     session[:last_cohort_upload_count] = @cohort_import.rows.count
 
     redirect_to action: :success

app/models/cohort_import.rb

@@ -71,4 +71,8 @@ def process_row(row)
 
     :new_record_count
   end
+
+  def record_rows
+    # TODO: implement this when we create draft patients
+  end
 end

app/models/concerns/csv_importable.rb

@@ -5,6 +5,8 @@
 module CSVImportable
   extend ActiveSupport::Concern
 
+  include Recordable
+
   included do
     attr_accessor :csv_is_malformed, :data, :rows
 
@@ -86,6 +88,18 @@ def process!
     end
   end
 
+  def record!
+    return if recorded?
+
+    process! unless processed?
+    return if invalid?
+
+    ActiveRecord::Base.transaction do
+      record_rows
+      update!(recorded_at: Time.zone.now)
+    end
+  end
+
   def remove!
     return if csv_removed?
     update!(csv_data: nil, csv_removed_at: Time.zone.now)

app/models/immunisation_import.rb

@@ -30,7 +30,6 @@
 #
 class ImmunisationImport < ApplicationRecord
   include CSVImportable
-  include Recordable
 
   belongs_to :programme
 
@@ -42,31 +41,6 @@ class ImmunisationImport < ApplicationRecord
     has_many :patients
   end
 
-  def record!
-    return if recorded?
-
-    process! unless processed?
-    return if invalid?
-
-    recorded_at = Time.zone.now
-
-    ActiveRecord::Base.transaction do
-      vaccination_records.draft.each do |vaccination_record|
-        if (patient_session = vaccination_record.patient_session).draft?
-          patient_session.update!(active: true)
-        end
-
-        if (session = vaccination_record.session).draft?
-          session.update!(active: true)
-        end
-
-        vaccination_record.update!(recorded_at:)
-      end
-
-      update!(recorded_at:)
-    end
-  end
-
   private
 
   def required_headers
@@ -116,4 +90,18 @@ def process_row(row)
       :not_administered_record_count
     end
   end
+
+  def record_rows
+    vaccination_records.draft.each do |vaccination_record|
+      if (patient_session = vaccination_record.patient_session).draft?
+        patient_session.update!(active: true)
+      end
+
+      if (session = vaccination_record.session).draft?
+        session.update!(active: true)
+      end
+
+      vaccination_record.update!(recorded_at: Time.zone.now)
+    end
+  end
 end

spec/models/immunisation_import_spec.rb

@@ -279,12 +279,6 @@
       let(:programme) { create(:programme, :flu_all_vaccines, academic_year:) }
       let(:file) { "valid_flu.csv" }
 
-      it "sets the recorded at time" do
-        expect { record! }.to change(immunisation_import, :recorded_at).from(
-          nil
-        )
-      end
-
       it "records the vaccination records" do
         expect { record! }.to change(VaccinationRecord.recorded, :count).from(
           0
@@ -302,12 +296,6 @@
       let(:programme) { create(:programme, :hpv_all_vaccines, academic_year:) }
       let(:file) { "valid_hpv.csv" }
 
-      it "sets the recorded at time" do
-        expect { record! }.to change(immunisation_import, :recorded_at).from(
-          nil
-        )
-      end
-
       it "records the vaccination records" do
         expect { record! }.to change(VaccinationRecord.recorded, :count).from(
           0

spec/support/a_csv_importable_model.rb

@@ -57,6 +57,17 @@
     end
   end
 
+  describe "#record!" do
+    let(:today) { Time.zone.local(2025, 1, 1) }
+
+    it "sets recorded_at" do
+      expect { travel_to(today) { subject.record! } }.to change(
+        subject,
+        :recorded_at
+      ).from(nil).to(today)
+    end
+  end
+
   describe "#remove!" do
     let(:today) { Time.zone.local(2020, 1, 1) }