Modify good-job related configuration

- Ensure development is in async mode
  - Currently default is external
- No longer need to load good-job workers with puma on user-facing servers

Author: TheOneFromNorway

config/environments/development.rb

@@ -81,6 +81,9 @@
   # Prevent health checks from clogging up the logs.
   config.silence_healthcheck_path = "/up"
 
+  # Set up GoodJob for async execution in development mode
+  config.good_job.execution_mode = :async
+
   # Enable strict loading to catch N+1 problems.
   config.active_record.strict_loading_by_default = true
   config.active_record.strict_loading_mode = :n_plus_one_only

config/puma.rb

@@ -57,21 +57,5 @@
 # processes).
 workers Settings.web_concurrency
 
-if Settings.web_concurrency > 1
-  # Cleanly shut down GoodJob when Puma is shut down.
-  # See https://github.com/bensheldon/good_job#execute-jobs-async--in-process
-  MAIN_PID = Process.pid
-  before_fork { GoodJob.shutdown }
-  on_worker_boot { GoodJob.restart }
-  on_worker_shutdown { GoodJob.shutdown }
-  at_exit { GoodJob.shutdown if Process.pid == MAIN_PID }
-
-  # Use the `preload_app!` method when specifying a `workers` number.
-  # This directive tells Puma to first boot the application and load code
-  # before forking the application. This takes advantage of Copy On Write
-  # process behavior so workers use less memory.
-  preload_app!
-end
-
 # Re-open appenders after forking the process; needed for Semantic Logger
 on_worker_boot { SemanticLogger.reopen }