Merge pull request #4321 from nhsuk/systm-one-no-location

Handle `nil` vaccination record location

Author: thomasleese

app/lib/reports/systm_one_exporter.rb

@@ -89,7 +89,14 @@ def vaccination_records
         .administered
         .where(programme:)
         .for_academic_year(academic_year)
-        .includes(:batch, :location, :vaccine, :patient, :performed_by_user)
+        .includes(
+          :batch,
+          :location,
+          :patient,
+          :performed_by_user,
+          :session,
+          :vaccine
+        )
 
     if start_date.present?
       scope =
@@ -148,11 +155,19 @@ def row(vaccination_record:)
     ]
   end
 
-  # TODO: Needs support for community and generic clinics.
   def practice_code(vaccination_record)
     location = vaccination_record.location
 
-    location.school? ? location.urn : location.ods_code
+    if location&.school?
+      location.urn
+    elsif location
+      location.ods_code
+    else
+      # TODO: Needs support for generic clinics. The `location_id` is
+      #  `nil` but `location_name` is a human-readable string, so we
+      #  have no choice but to use the location of the session.
+      vaccination_record.session.location.ods_code
+    end
   end
 
   def gender_code(code)

spec/factories/vaccination_records.rb

@@ -103,7 +103,7 @@
     uuid { SecureRandom.uuid }
 
     location { session&.location unless session&.generic_clinic? }
-    location_name { "Unknown" if session.nil? }
+    location_name { "Unknown" if location.nil? }
 
     notify_parents { true }
 

spec/lib/reports/systm_one_exporter_spec.rb

@@ -149,9 +149,15 @@
     subject { csv_row["Practice code"] }
 
     context "location is a gp clinic" do
-      let(:location) { create(:gp_practice) }
+      let(:location) { create(:gp_practice, team:) }
 
-      it { should eq location.ods_code }
+      it { should eq(location.ods_code) }
+    end
+
+    context "location is a generic clinic" do
+      let(:location) { create(:generic_clinic, team:) }
+
+      it { should eq(location.ods_code) }
     end
   end