Ensure reliable NHS number retrieval from search results

Previously, `nhs_number` within `patient_changeset.search_results` was accessed using symbol keys (e.g., `sr[:nhs_number]`). However, when `search_results` (stored in a `jsonb` column) are deserialized from the database, they become standard Ruby `Hash` objects with string keys, causing symbol access to fail if `with_indifferent_access` was not effectively preserved.

This commit updates the `unique_nhs_numbers` method to consistently use string keys (`sr["nhs_number"]`) for accessing the NHS number.

Author: murugapl

app/jobs/process_patient_changesets_job.rb

@@ -51,7 +51,11 @@ def perform(patient_changeset, step_name = nil)
   private
 
   def unique_nhs_numbers(patient_changeset)
-    patient_changeset.search_results.pluck(:nhs_number).compact.uniq
+    patient_changeset
+      .search_results
+      .map { |sr| sr["nhs_number"] || sr[:nhs_number] }
+      .compact
+      .uniq
   end
 
   def get_unique_nhs_number(patient_changeset)

spec/features/import_child_pds_lookup_extravaganza_spec.rb

@@ -343,11 +343,15 @@ def and_pds_lookup_during_import_is_enabled
       address_postcode: "W2 3PE"
     )
 
-    stub_all_searches_to_return_no_patient(
+    stub_pds_cascading_search(
       family_name: "Richard",
       given_name: "Caroline",
       birthdate: "eq2010-05-15",
-      address_postcode: "B1 1AA"
+      address_postcode: "B1 1AA",
+      steps: {
+        wildcard_postcode: "1111111111",
+        fuzzy: "9435726097"
+      }
     )
   end
 
@@ -386,17 +390,57 @@ def stub_all_searches_to_return_no_patient(
       "given" => given_name,
       "birthdate" => birthdate,
       "address-postalcode" => address_postcode,
-      "_fuzzy-match" => "true",
-      "_history" => "false"
+      "_fuzzy-match" => "true"
     )
+  end
+
+  def stub_pds_cascading_search(
+    family_name:,
+    given_name:,
+    birthdate:,
+    address_postcode:,
+    steps: {}
+  )
     stub_pds_search_to_return_no_patients(
       "family" => family_name,
       "given" => given_name,
       "birthdate" => birthdate,
-      "address-postalcode" => address_postcode,
-      "_fuzzy-match" => "true",
-      "_history" => "true"
+      "address-postalcode" => address_postcode
     )
+
+    {
+      wildcard_postcode: {
+        "family" => family_name,
+        "given" => given_name,
+        "birthdate" => birthdate,
+        "address-postalcode" => "#{address_postcode[0..1]}*"
+      },
+      wildcard_given_name: {
+        "family" => family_name,
+        "given" => "#{given_name[0..2]}*",
+        "birthdate" => birthdate,
+        "address-postalcode" => address_postcode
+      },
+      wildcard_family_name: {
+        "family" => "#{family_name[0..2]}*",
+        "given" => given_name,
+        "birthdate" => birthdate,
+        "address-postalcode" => address_postcode
+      },
+      fuzzy: {
+        "family" => family_name,
+        "given" => given_name,
+        "birthdate" => birthdate,
+        "address-postalcode" => address_postcode,
+        "_fuzzy-match" => "true"
+      }
+    }.each do |step, query|
+      if steps[step]
+        stub_pds_search_to_return_a_patient(steps[step], **query)
+      else
+        stub_pds_search_to_return_no_patients(**query)
+      end
+    end
   end
 
   def when_i_visit_the_import_page

spec/support/pds_helper.rb

@@ -2,8 +2,7 @@
 
 module PDSHelper
   def stub_pds_search_to_return_no_patients(**query)
-    query["_history"] ||= "true"
-    query.delete("_history") if query["_history"] == "false"
+    query["_history"] = "true" unless query["_fuzzy-match"] == "true"
 
     stub_request(
       :get,
@@ -19,7 +18,7 @@ def stub_pds_search_to_return_no_patients(**query)
   end
 
   def stub_pds_search_to_return_a_patient(nhs_number = "9449306168", **query)
-    query["_history"] ||= "true"
+    query["_history"] = "true" unless query["_fuzzy-match"] == "true"
 
     response_data =
       JSON.parse(file_fixture("pds/search-patients-response.json").read)